server: reformat/refactor around redirects #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeorpinel
commented
Feb 4, 2020
shcheklein
reviewed
Feb 4, 2020
shcheklein
reviewed
Feb 4, 2020
shcheklein
reviewed
Feb 4, 2020
shcheklein
reviewed
Feb 4, 2020
|
minor questions, otherwise looks good |
|
@jorgeorpinel any updates on this? |
jorgeorpinel
changed the title
per #973 (review) through #973 (review)
|
Sorry for the delay. Addressed your feedback now, @shcheklein. |
shcheklein
approved these changes
Feb 19, 2020
shcheklein
added a commit
that referenced
this pull request
Feb 19, 2020
This reverts commit 3c5522d.
jorgeorpinel
added a commit
that referenced
this pull request
Feb 20, 2020
per #973 (review) through #973 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For demo of suggested changes. (Not sure whether we'll move to merge these changes here.)