Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar: do not highlight links on hover #945

Conversation

fabiosantoscode
Copy link
Contributor

Fixes #618


Disregard the recommendations below if you use Edit on GitHub button to improve the docs in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This enables GitHub to link the PR to the corresponding bug and close it automatically when PR is merged.

Thank you for the contribution - we'll try to review and merge it as soon as possible. 🙏

@shcheklein
Copy link
Member

@fabiosantoscode CI checks are failing

@fabiosantoscode fabiosantoscode force-pushed the feature/618-do-not-highlight-sidebar-links-on-mobile-hover branch from 6aa7ad2 to ac8641b Compare January 24, 2020 21:00
@fabiosantoscode
Copy link
Contributor Author

@shcheklein It's an unrelated failure. Rebasing.

@shcheklein shcheklein temporarily deployed to dvc-landing-feature-618-v7dab8 January 24, 2020 21:18 Inactive
@shcheklein shcheklein merged commit 2edaf86 into iterative:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't allow for second item highlight in sidebar on scroll on mobile
2 participants