-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app: address some console errors #942
app: address some console errors #942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, it looks like we don't need this right? Could you check if Heroku sets env properly?
@shcheklein I did some digging yesterday before opening this PR, and I couldn't find any literature on Heroku which said it would run |
Didn't see that one! I'll revert that part then. |
@fabiosantoscode then we don't have anything else left on this PR, right? If ticket is not reproducible can we close it @jorgeorpinel ? |
Just the yarn.lock update @shcheklein |
abbe12f
to
c4b875d
Compare
Do you know why does it remove so much stuff in yarn? Also let's remove the "Fixes ..." from the description and comment in the issue that you was not able to reproduce it? |
That's right, it shouldn't close the issue at all. My bad. |
No idea why it removes so many packages. Someone might have done some spring cleaning on their dependencies. |
We probably didn't run an update in a while. |
The errors about the client pinging but the page not existing can only occur on the dev server. It shouldn't be running sincenpm start
is setting the NODE_ENV to production, but still I added the NODE_ENV environment variable to app.json just to make sure heroku isn't running server.js raw.Updated yarn.lock
Disregard the recommendations below if you use Edit on GitHub button to improve the docs in place.
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue
(if applicable) in the description of the PR. This enables GitHub to link the PR to the corresponding bug and close it automatically when PR is merged.Thank you for the contribution - we'll try to review and merge it as soon as possible. 🙏