tooltip: do not use a div container for tooltips #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting review @shcheklein, not sure who's responsible for this repository. |
|
I can review this one. Thanks for addressing this bug BTW! |
|
I deployed a review app and I can confirm the cases we posted in blah are fixed 🎉
In https://dvc-landing-feature-870-lynvht.herokuapp.com/doc/command-reference/gc#examples:
In https://dvc-landing-feature-870-lynvht.herokuapp.com/doc/command-reference/add#example-directory
|
|
@jorgeorpinel thanks for checking this out. What's next? |
shcheklein
approved these changes
Jan 10, 2020
|
@jorgeorpinel please feel free to approve and merge if you don't see any other issues. |
I was just waiting for your reply in #913 (review) Now we approve and merge it 🙂 |
jorgeorpinel
approved these changes
Jan 10, 2020
|
🎆 first merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem with Tooltips being misplaced on Chrome when the text which shows the Tooltip is on the left hand side of a
<p>.This also fixes the annoying warnings from React that a
<div>is being placed inside of a<p>, because now it's a<span>.Note: Currently, if the tooltip is too long, it won't line-break. This PR does not change this, and It's probably a non-issue for now.
Fix #870