Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: create docs #908
api: create docs #908
Changes from all commits
d56f2d2
d53833f
aba4954
0f5a3bb
701aeb7
6a18d61
a3023be
09c76c5
8c14cbd
97c3972
6894e77
711838d
68a3dd0
95fa070
09db290
bb05e9c
58e4bb5
08fe226
c207152
4a50af9
89734fd
c094233
8b133ca
eec0848
9b58c3f
af3ee37
eeb318c
3e0b909
9cf939f
59bb2f2
e340321
cc4a7a8
24f2d67
e26ef15
026eaa2
3815a09
382b195
013f5df
e9340ce
0a725e8
d696063
f13b311
73adff5
6ebe371
a921b40
a6f9eec
c1eb598
4f42b88
ffc0117
8208fd9
910d319
1d5d3a9
a11465e
f86afde
979d70c
099dc4e
9e21825
4eb85b3
b6cd85e
11fb55e
be2316f
c94610d
9c52cd8
4219494
942d81d
e76bd5f
2b8b4a7
aa88cea
dc93bb8
f66826c
8b3929c
3ec79a0
fcdf0c4
e5b52ae
7f2981f
03d4e72
6ccfc80
418651d
7161e8c
a229803
c43e704
5acaffd
8840338
2e9dc3d
35674e3
42e8563
ed80616
c47b366
a1a6b34
a251259
af551be
7277e11
4f04a62
925f520
7105df6
a02b178
466694c
951742d
410622f
fcbdefd
8089423
e440284
4ee9335
6cd45b0
ce5b42a
f245cc8
6bd2740
90cb882
7733fea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super relevant example would to show SAX or StAX parser instead of a DOM one - that's where it shines. Or we can make CSV example the main one and show how we process it in steam fashion (e.g. calculating sum or avg) - it would show the "streaming" aspect of the
open()
way better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this, I don't think we're talking about real-time data streaming (e.g. from a Kafka server) so that continuously calculating a metric would be logical. Or maybe I missed the point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged the PR, but still thinking about this one. What's the advantage of streaming files in open/read? Probably just making a big file available quickly so you can start processing it before it's all downloaded, but again, I don't think you'll want to show the progress of such processing, or is that a major use case you guys see? Cc @Suor @shcheklein
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this discussion to a new PR: #1037