Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add interactive button to run get-started/ tutorials as Google Colabs, Katacoda, Kaggle kernels, etc. #670 #824

Merged
merged 11 commits into from
Dec 4, 2019

Conversation

iAdramelk
Copy link
Contributor

@iAdramelk iAdramelk commented Nov 28, 2019

This is a first draft for the feature then we show links to tutorials in the sidebar.

We can add links to tutorials to the sidebar.json file now like that:

tutorials: {
  katacoda: "https://www.katacoda.com/loodse/courses/docker/docker-02-install"
}

I assume for now that we will only have one tutorial link per site. If it is not correct, we will need to change the structure.

Links will be shown in the right panel on the documentation page under the list of headers. If the tutorial's key is in the list of known sites, an icon will be shown before it (right now, I only added katacoda.com icon).

You can check how it looks right now at the /doc/get-started/connect-code-and-data page.

ToDo:

  • Update design.
  • Add multiple tutorial site icons. (And somehow decide how we can get icons that we can use according to copyright).
  • Replace an example link with the real links to the tutorials.

@shcheklein shcheklein temporarily deployed to dvc-org-pr-824 November 28, 2019 06:39 Inactive
@iAdramelk
Copy link
Contributor Author

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 🎉

Can we make it a button - similar to Github and Chat?

Let's also show the Katacoda icon (+tooltip that explains it when you hover) and/or play button after the top title? We need to make it a bit more visible.

Copy link
Contributor

@dashohoxha dashohoxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this button on the right side makes sense only if it is used on the index page of Get Started and the index page of the tutorials, namely:

But this is ok, since on the other cases we can use simple links (or styled links), like those that I have proposed here: https://github.com/iterative/dvc.org/pull/786/files

In particular, for command references or UG pages there may be more than one relevant interactive examples, and they may correspond to specific parts of the page (like example sections) not to the whole page, so using inline links might be more suitable than buttons on the right side.

One thing that might be useful for inline links is to style them like a button, if possible. For example we can use a syntax like this:

<button class="interactive">
  [Try interactive example](https://katacoda.com/dvc/courses/examples/fetch)
</button>

But this is not related to this PR.

@shcheklein
Copy link
Member

I don't see a good place for explicit links - before content they distract too much, after content they are not visible.

I think PR deprecates the one here #786 . If we'll need multiple buttons, or a button per example we'll use links and/or add a special syntax.

@shcheklein shcheklein temporarily deployed to dvc-org-pr-824 November 29, 2019 11:01 Inactive
@iAdramelk
Copy link
Contributor Author

@shcheklein Replaced tutorials to the ones from #786, updated link to look like button, made katacoda icon larger.

What should we write in the tooltip?

@shcheklein
Copy link
Member

Let's change screen icon with a play button icon.

Tooltip. Do you mean that "Need a tutorial?" text? I would replace it with "It can be run online".

We need to do something with a mobile version. As I suggested let's show an icon close to the main title.

@dashohoxha @jorgeorpinel what do you think, is the current button visible enough?

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments and suggested improvements. Good stuff @iAdramelk 🎉

@dashohoxha
Copy link
Contributor

what do you think

I don't really have anything to say, other than @iAdramelk has done a nice job.

@shcheklein shcheklein temporarily deployed to dvc-org-pr-824 December 2, 2019 14:06 Inactive
@iAdramelk
Copy link
Contributor Author

Added mobile styles for the tutorial buttons and changed icon+text for the right column.

@shcheklein
Copy link
Member

@iAdramelk looks great! One issue I see is that button is not clickable on the mobile version, some minor bug probably.

@shcheklein
Copy link
Member

Also, please rebase/merge.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Dec 3, 2019

Should the description say "Fixes #670"?

Direct link to example: https://dvc-org-pr-824.herokuapp.com/doc/get-started/connect-code-and-data

@jorgeorpinel what do you think, is the current button visible enough?

I don't see the button at the moment. Please lmk when to review. 🙂

@shcheklein
Copy link
Member

@jorgeorpinel check this link - https://dvc-org-pr-824.herokuapp.com/doc/get-started :)

@shcheklein shcheklein temporarily deployed to dvc-org-pr-824 December 3, 2019 11:57 Inactive
@iAdramelk
Copy link
Contributor Author

Fixed bug with unclickable buttons, and rebased branch to master.

@shcheklein
Copy link
Member

@iAdramelk looks great!

Out of three checkboxes what are still pending? I'm not sure I understand the Add multiple tutorial site icons.

Update design, I assume, is done, right?

@iAdramelk
Copy link
Contributor Author

@shcheklein If we are ok with the design, we can check design item out.

Add multiple tutorial site icons – it is about different possible platforms that we can use in the future. Right now I only added Katacoda icon, but I didn't add icons for Kaggle, Google Collabs and other platforms. Not sure if we need them right now through.

Replace an example link with the real links to the tutorials. – I transferred 4 links that I know about from the other PR. But I'm not sure if I found and added all of the existing tutorials on Katacoda.

@dashohoxha
Copy link
Contributor

But I'm not sure if I found and added all of the existing tutorials on Katacoda.

Right now there are also these corresponding Katacoda tutorials that you might add:

@dashohoxha
Copy link
Contributor

@iAdramelk you might also need to fix this PR by adding interactive buttons to the corresponding pages: #784
But I am not sure, you may need approval for doing this.
Anyways, it might be better to wait until that PR is merged (if it is merged) and add the interactive buttons later.

@iAdramelk
Copy link
Contributor Author

@dashohoxha added links to the three pages above (same link for pipelines and deep). Will skip #784 for now.

@shcheklein
Copy link
Member

@dashohoxha I would also probably add button to some get started sections to point to specific Get Started interactive tutorials? That was the idea, right?

@shcheklein
Copy link
Member

@iAdramelk

Thanks : 🙏

Not sure if we need them right now through.

we don't need them now

Replace an example link with the real links to the tutorials.

No need to do all the links as part of this PR. This is about engine in the first place.

@shcheklein shcheklein merged commit 803cc71 into master Dec 4, 2019
@shcheklein shcheklein deleted the gf-fix_#670 branch December 18, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants