Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded general commit component dvc #754

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl added A: docs Area: user documentation (gatsby-theme-iterative) user-guide labels Oct 28, 2019
@casperdcl casperdcl self-assigned this Oct 28, 2019
@shcheklein shcheklein merged commit b477f06 into iterative:master Oct 28, 2019
Comment on lines -302 to 305
- _component_: Name of a component that this patch is affecting. Use `dvc` in a
general case
- _component_: If applicable, comma-separated list of affected component(s)
- _short description_: Short description of the patch
- _long description_: If needed, longer message describing the patch in more
details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just want @iterative/engineering to note this doc change and confirm this is generally the convention they use, or are able to adopt. (This are conventions for commit messages.) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants