-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #563: How to keep data and cache on external drive #732
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done an extensive check but just looking at the first file in my first commit, lines 40-43 (abd2446#diff-278c4173e3a65d532906f6a613dc7ce0R40-R43) for example are not included in this PR.
I guess there was a reason to so it, but having closed the original PR and opened a new one from a different branch makes it extra time consuming to track and review the continuity in these changes. I tried just doing git cherry-pick
to apply my work again, but since the file is located somewhere else, this method does not work.
We'll probably have to manually compare and reapply my changes (combined here: 482e1c7...f345245) vs those in this PR.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, a great article, I would just rename the file to something shorter.
static/docs/user-guide/howto/keep-data-and-cache-on-external-drive.md
Outdated
Show resolved
Hide resolved
static/docs/user-guide/howto/keep-data-and-cache-on-external-drive.md
Outdated
Show resolved
Hide resolved
static/docs/user-guide/howto/keep-data-and-cache-on-external-drive.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest concern is that I don't understand the motivation for this combination. It's very very specific one of the few ways organizing this. Why do we pick and when do we pick this one it's not clear.
This comment has been minimized.
This comment has been minimized.
I changed the title and rewrote the motivation. I hope it looks better now. I was tempted again to remove the reference about Windows (https://github.com/iterative/dvc.org/pull/732/files#diff-e67a9ecb076e21d068e0f5559ed64582R30) but I didn't dare. @jorgeorpinel it really seems out of place to me, please think about removing it again. |
btw, @dashohoxha how does this one correlate with the new data sharing section? |
I don't see any correlation. |
we have to make sure that we can read and write the `/data/` directory: | ||
|
||
```dvc | ||
$ sudo chown <username>: -R /data/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not right to provide chown, chmod and other commands to manage permissions. They are not actionable anyway. Exact commands you need to run depend on the case. Some general suggestions to check the permissions should be enough?
@@ -0,0 +1,151 @@ | |||
# Keep Data and Cache Outside the Project | |||
|
|||
Sometimes we would like to keep the data and cache outside the project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how is it related to being able to search code tbh, could you elaborate?
Sometimes we would like to keep the data and cache outside the project | ||
directory, so that we can search easily the code of the project. | ||
|
||
Keeping the data outside of the project, on a fixed absolute path, is also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a a very tricky case - if multiple projects use the same data how do they switch different versions?
closing this as stale |
Fix #563
Replaces #565