-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #525: How to fix autocomplete on debian/ubuntu #537
Conversation
Instructions for fixing bash autocomplete on debian/ubuntu. Closes #525 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dashohoxha looks good! Please, check the docs contributing guide and fix small stylistic issues here and there.
I fixed the formatting (with prettier) and also fenced code blocks (although I think they are not necessary in this case, because there are no But please let's keep "it is" and "does not" as they are. I know English as well as you do, and I know the difference between them and their short forms. It is not only about more/less formal but it is also about emphasis. They sound better to me the way they are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 🎉 !
My only comment on the "does not" and "is not" etc is that we want the docs, as much as possible, to sound like the same person wrote it all for familiarity. It's about consistency, not correctness. Thus I'm changing them in 2b96e0e (for my next PR). Thanks |
Instructions for fixing bash autocomplete on debian/ubuntu. Fix #525