Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp run: add options from repro #4704

Merged
merged 2 commits into from
Jul 18, 2023
Merged

exp run: add options from repro #4704

merged 2 commits into from
Jul 18, 2023

Conversation

dberenbaum
Copy link
Contributor

Fixes #4495

@dberenbaum dberenbaum requested a review from a team July 18, 2023 20:25
shcheklein
shcheklein approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! we need to remove the note on line 85 I think.

@shcheklein shcheklein temporarily deployed to dvc-org-exp-run-options-kun1aj July 18, 2023 20:30 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023 •
edited
Loading

Link Check Report

There were no links to check!

@shcheklein shcheklein temporarily deployed to dvc-org-exp-run-options-kun1aj July 18, 2023 21:30 Inactive
@dberenbaum dberenbaum merged commit 5fc7d23 into main Jul 18, 2023
@dberenbaum dberenbaum deleted the exp-run-options branch July 18, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exp run: Explicitly document repro options.
2 participants
@dberenbaum @shcheklein