Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page about Studio REST API #4681
Add page about Studio REST API #4681
Changes from 10 commits
5260c54
c031684
d10fb04
9d7f82b
0c7c289
7d1fb17
832efae
ba1fe76
5059499
3e22bfc
4c971c6
d777c0a
2f46406
ef0c38c
0855839
7134202
a4f66a2
b291eee
f68bf78
d0139df
a6493f4
87f9402
bb54bda
e2aa45a
b87e2f7
166599d
ef27fc3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also support a Studio project ID per https://github.com/iterative/studio/pull/6338#issuecomment-1596468450? My feeling is it still might be useful since users have to do a lookup either way and this requires less escaping than a full repo url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not rn. But we can add it in some future. Adding this as an item to "out of scope of phase I" https://github.com/iterative/studio/issues/5177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amritghimire Is this implemented? When I try it, I get an error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an example for monorepo. @dberenbaum wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it required to include
results/train
in this case?Edit: okay, I think I know that the answer is yes, since artifact names are specific to the dvc.yaml file, right? If there are no conflicts, can we omit
results/train
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think we can omit that. We need to implement it on BE side I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try to wget the resulting model, I'm getting a 403 forbidden error.
Also, let's remember that we need to replace this example with one that works in example-get-started-experiments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generated link isn't correct because
iterative/demo-bank-customer-churn.git
project doesn't have creds set up. Adding this as a bug to that umbrella issue.