Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download: re-enable osx pkg #4625

Merged
merged 1 commit into from
Jun 14, 2023
Merged

download: re-enable osx pkg #4625

merged 1 commit into from
Jun 14, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jun 14, 2023

With osxpkg building fixed and 3.0 package already available, we can now re-enable osx download button on dvc.org.

@efiop efiop requested a review from a team as a code owner June 14, 2023 21:43
@efiop
Copy link
Contributor Author

efiop commented Jun 14, 2023

Doesn't seem like it is caused by me

info     Restyler started                owner="iterative" pull=4625 repo="dvc.org"
info     Cloning repository             
debug    Switched to branch 'pull-4625' 
info     Fetching remote file            path="/tmp/restylers-stable.yaml"
info     Restyling                       restyler="prettier" style="many files, with separator"
debug    [error] src/components/DownloadButton/index.tsx: Error: Cannot find module '@dvcorg/gatsby-theme-iterative/tailwind.config'
debug    [error] Require stack:         
debug    [error] - /code/tailwind.config.js
debug    [error]     at Module._resolveFilename (node:internal/modules/cjs/loader:1082:15)
debug    [error]     at Function.resolve (node:internal/modules/helpers:127:19)
debug    [error]     at qt (/app/node_modules/prettier-plugin-tailwindcss/dist/index.js:49:11642)
debug    [error]     at Cr (/app/node_modules/prettier-plugin-tailwindcss/dist/index.js:49:13228)
debug    [error]     at /code/tailwind.config.js:1:96
debug    [error]     at Cr (/app/node_modules/prettier-plugin-tailwindcss/dist/index.js:49:14762)
debug    [error]     at _V (/app/node_modules/prettier-plugin-tailwindcss/dist/index.js:2274:3692)
debug    [error]     at Object.parse (/app/node_modules/prettier-plugin-tailwindcss/dist/index.js:2371:7066)
debug    [error]     at Object.parse (/app/node_modules/prettier/index.js:7515:23)
debug    [error]     at coreFormat (/app/node_modules/prettier/index.js:8829:18)
warn     callProcessExitCode             arguments=["run","--rm","--net","none","--cap-drop","all","--cpu-shares","128","--memory","512m","--volume","/tmp/restyler-1:/code","restyled/restyler-prettier:v2.8.8-1","prettier","--write","--config=./.prettierrc","--ignore-path=./.prettierignore","--","./src/components/DownloadButton/index.tsx"] command="docker" exitCode=2
error    Exception:
Restyler prettier exited non-zero (2)
  Error information may be present in debug messages printed above

  Help:
    https://prettier.io/docs/en/ error={description:"a Restyler errored",exitCode:20,severity:"warning",tag:"restyler"}
info     Restyler done                   exitCode=20

@efiop efiop merged commit c9c5c02 into main Jun 14, 2023
@efiop efiop deleted the efiop-patch-1 branch June 14, 2023 21:49
@shcheklein
Copy link
Member

Doesn't seem like it is caused by me

Yes, I contacted Patrick (@pbrisbin) . It should be fixed now and will deployed within a week cc @yathomasi .

@github-actions
Copy link
Contributor

Link Check Report

There were no links to check!

@yathomasi
Copy link
Contributor

It should be fixed now and will deployed within a week

I see they have now mentioned integration with tailwindcss which I guess is good but I am not sure it will cover the current issue scenario for us.

If not, we plan to use a custom image with the required package installed: iterative/gatsby-theme-iterative#216.

@shcheklein
Copy link
Member

I see they have now mentioned integration with tailwindcss which I guess is good but I am not sure it will cover the current issue scenario for us.

Here is the fix restyled-io/restylers#513 just for the context.

@yathomasi
Copy link
Contributor

Thanks. It will definitely cover https://restyled.io/gh/iterative/repos/iterative.ai/jobs/3272004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants