Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repro: Updated --pull and added --allow-missing. #4575

Merged
merged 2 commits into from
May 31, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented May 29, 2023

Added Example: Only pull pipeline data as needed.

Added Example: Only pull pipeline data as needed.
@daavoo daavoo self-assigned this May 29, 2023
@daavoo daavoo linked an issue May 29, 2023 that may be closed by this pull request
@daavoo daavoo requested a review from a team May 29, 2023 15:19
@daavoo daavoo added the C: ref Content of /doc/*-reference label May 29, 2023
@shcheklein shcheklein temporarily deployed to dvc-org-4551-exp-runrep-v4po2j May 29, 2023 15:20 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

Link Check Report

There were no links to check!

Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of this is blocking, but a few thoughts:

Minor, but what do you think of moving or copying the example to the guide?

Can we add another example like "verify pipeline is up to date without pulling data" to address iterative/dvc#5369? It can use --allow-missing --dry and show how it succeeds (returns 0) if it's up to date but fails otherwise. Maybe it also belongs in the guide, and we could also include a way to check that all the data exists on the remote using the output of dvc data status --not-in-remote.

@daavoo daavoo merged commit 43c5065 into main May 31, 2023
@daavoo daavoo deleted the 4551-exp-runrepo-pull-allow-missing branch May 31, 2023 13:06
@daavoo
Copy link
Contributor Author

daavoo commented May 31, 2023

Minor, but what do you think of moving or copying the example to the guide?

Where in the guide?

@dberenbaum
Copy link
Contributor

Where in the guide?

Discussed with @daavoo that it could go in https://dvc.org/doc/user-guide/pipelines/running-pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: ref Content of /doc/*-reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exp run/repo --pull/--allow-missing
3 participants