-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: create Remote Reference (config) #4264
Conversation
Co-authored-by: Restyled.io <[email protected]>
Hi @dberenbaum, me again... So far this only creates the first of a proposed page-per-remote Ref section (could be renamed or moved to a wider Configuration Ref). This was pretty-labor intensive so let's review this one first to decide whether to move fwd with this strategy. Thanks, PTAL when you can:
|
Discussed a bit with @shcheklein and we agreed this is a good direction (long overdue) but also to further simplify cmd refs and to bury these pages under the Data Management guide for now (we expect readers to find them via search results or links probably)... ⌛ |
I really like the changes and the separated page. |
Yup, direction looks good! Thank you @jorgeorpinel! |
Agree with @daavoo that if we go this direction, I don't think we should keep this part of the cmd ref at all.
Not sure I follow. What pages do you want to bury? I really like the top-level remote ref section you added. Edit: if it's getting to be too many top-level sections, we could have one top-level "Reference" section with subsections like "Command," "Python API," "Remote", "File." |
and some typo fixes
and remove repeated content from cmd refs (link to guide)
OK, I'm just listing the remote types in 3 places then: the Remote Storage guide index page, the
To avoid introducing a new top-level section on the docs nav, we are burying the specific storage type pages under User Guide -> Data Management -> Remote Storage -> each page (e.g. S3). Not expecting people to navigate there by clicking the nav (but rather links or search results), this should be fine 🐶🔥. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dberenbaum should we review this now? The PR is starting to grow too much. Maybe we can merge it in with just the first type in and I'll then make another PR for the remaining ones. Cc @shcheklein
Also, this PR already has a child to update related links (#4282)...
List of changes:
"remote-storage", | ||
{ | ||
"slug": "remote-storage", | ||
"source": "remote-storage/index.md", | ||
"children": ["amazon-s3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this into a section (moved remote-storage.md to remote-storage/index.md)
# Amazon S3 | ||
|
||
`dvc remote add` a (new) remote name and a valid [S3] URL: | ||
|
||
```cli | ||
$ dvc remote add -d myremote s3://<bucket>/<key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created Amazon S3 page, we can use as template for the remaining types.
## S3-compatible servers (non-Amazon) | ||
|
||
Set the `endpointurl` parameter with the URL to connect to the S3-compatible | ||
service (e.g. [MinIO], [IBM Cloud Object Storage], etc.). For example, let's set | ||
up a [DigitalOcean Space] (equivalent to a bucket in S3) called `mystore` found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Amazon S3 page includes the non-Amazon, S3-compatible section, since it only involves one config option.
### Amazon S3 | ||
|
||
> 💡 Before adding an S3 remote, be sure to | ||
> [Create a Bucket](https://docs.aws.amazon.com/AmazonS3/latest/gsg/CreatingABucket.html). | ||
|
||
```cli | ||
$ dvc remote add -d myremote s3://mybucket/path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S3 info is now totally removed (just linked instead) from remote add
...
### S3-compatible storage | ||
|
||
For object storage that supports an S3-compatible API (e.g. | ||
[Minio](https://min.io/), | ||
[DigitalOcean Spaces](https://www.digitalocean.com/products/spaces/), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(including S3-compatible)
### Amazon S3 | ||
|
||
- `url` - remote location, in the `s3://<bucket>/<key>` format: | ||
|
||
```cli | ||
$ dvc remote modify myremote url s3://mybucket/path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and from remote modify
### S3-compatible storage | ||
Each type of storage has different config options you can set. See all the | ||
details in the pages linked below. | ||
|
||
- `endpointurl` - URL to connect to the S3-compatible storage server or service | ||
(e.g. [Minio](https://min.io/), | ||
[DigitalOcean Spaces](https://www.digitalocean.com/products/spaces/), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(including S3-compatible as well)
## File systems (local remotes) | ||
|
||
<admon type="tip"> | ||
|
||
Not related to the `--local` option of `dvc remote` and `dvc config`! | ||
|
||
</admon> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is the same as what's now in https://dvc.org/doc/user-guide/data-management/remote-storage (I guess I moved it in separate commits so the Git diff isn't clear),
except for this new section on local remotes, which (like S3-compatible) I'm not sure require their own page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the changes are mainly links and admonitions around this new section and other changes here.
Note there's also a nested PR specifically for link updates as well: #4282
update admonitions and links
d07f2bf
to
94a16c1
Compare
Sorry @dberenbaum, it was during a call but the logic is pretty much what I wrote. Either way it's a simple change to make but it may be best to decide before merging to avoid having to make redirects soon after.
I've solved conflicts for now so this is ready for merge, I think. |
80d251c
to
2badd87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jorgeorpinel! Added a couple small edits to clarify, especially while we are in limbo trying to transfer all the ref info to guides. As long as it looks okay with those changes, I'll go ahead and merge.
content/docs/user-guide/data-management/remote-storage/amazon-s3.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Restyled.io <[email protected]>
content/docs/user-guide/data-management/remote-storage/index.md
Outdated
Show resolved
Hide resolved
* ref: start Remote Reference (config) * Restyled by prettier (#4265) Co-authored-by: Restyled.io <[email protected]> * guide: move Remote Storage ref into Data Mgmt * start: links to new Remotes guide and and some typo fixes * guide: finalize S3 storage page and and remove repeated content from cmd refs (link to guide) * guide: link to remote storage types in link * guide: move "local remotes" to Remotes (index page) and update admonitions and links * ref: remove S3 examples * guide: emphasize that remotes use regular cloud storage config * Update content/docs/user-guide/data-management/remote-storage/amazon-s3.md * guide: drop `worktree` cloud versioning from Remotes Config per #4264 (comment) * guide: move cloud versioning near the top of Remote Config per #4264 (review) --------- Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Dave Berenbaum <[email protected]>
LGTM |
* ref: start Remote Reference (config) * Restyled by prettier (#4265) Co-authored-by: Restyled.io <[email protected]> * guide: move Remote Storage ref into Data Mgmt * start: links to new Remotes guide and and some typo fixes * guide: finalize S3 storage page and and remove repeated content from cmd refs (link to guide) * guide: move "local remotes" to Remotes (index page) and update admonitions and links * ref: remove S3 examples * guide: Azure remote page and start GCS * guide: finish GCS page and improvements to the other ones (S3, Azure) * guide: small link fix in GDrive how-to * guide: emphasize that remotes use regular cloud storage config * Update content/docs/user-guide/data-management/remote-storage/amazon-s3.md * guide: drop `worktree` cloud versioning from Remotes Config per #4264 (comment) * guide: move cloud versioning near the top of Remote Config per #4264 (review) * fix a link * typo * reformat all storage types (Data Mgmt/ Remote Storage) * guide: move admon about pending Remote guides up rel. #4284 (review) * link all remote types (instead of admon) per #4284 (review) * Restyled by prettier (#4333) Co-authored-by: Restyled.io <[email protected]> * Update content/docs/user-guide/data-management/remote-storage/amazon-s3.md Co-authored-by: Jorge Orpinel <[email protected]> --------- Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Dave Berenbaum <[email protected]>
Addresses the main part of #2866:
Maybe also
In review app: https://dvc-org-guide-data-mgmt-leaijc.herokuapp.com/doc/user-guide/data-management/remote-storage
AFTER: