Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: detailed plots spec for x and y fields #4188

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

dberenbaum
Copy link
Contributor

Fixes #4173

@shcheklein shcheklein temporarily deployed to dvc-org-plots-schema-p96u4kx5h December 16, 2022 11:49 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

30c0e98

Link Check Report

There were no links to check!

@shcheklein
Copy link
Member

Thanks @dberenbaum !

@dberenbaum dberenbaum merged commit 30c0e98 into main Dec 16, 2022
@dberenbaum dberenbaum deleted the plots-schema branch December 16, 2022 22:05
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference labels Dec 22, 2022
@jorgeorpinel jorgeorpinel changed the title dvc guide: detail plots spec for x and y guide: detailed plots spec for x and y fields Dec 22, 2022
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples for plot output fields could be useful (since there are so many for top-level plots). Specifically 👇🏼


- Plot outputs: column/field name found in the source plots file.
- **Plot outputs** (_string_): one column/field name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

template: confusion
```

- **Plot outputs** (_string_): one column/field name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

Comment on lines +106 to +119
If plot ID is an arbitrary string, `x` may either be one column/field name,
or a dictionary of file paths each mapped to one column/field name (the
number of column/field names must match the number in `y`).

```yaml
plots:
- train_val_test: # single x
y:
train.csv: [train_acc, val_acc]
test.csv: test_acc
x: epoch
- roc_vs_prc: # x dict
y:
precision_recall.json: precision
Copy link
Contributor

@jorgeorpinel jorgeorpinel Dec 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example is pretty long. Maybe we can summarize? And/or collapse the entire Plots/Available fields section (with <details>). For now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guide: clarify y field spec in top-level plots
3 participants