Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters: separate info among docs sections #3899

Merged
merged 105 commits into from
Sep 7, 2022
Merged

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Aug 26, 2022

On top of #3414

Exercise in guide vs. ref separation of concerns.

@shcheklein shcheklein temporarily deployed to dvc-org-params-refactor-my8p0m August 31, 2022 20:37 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-params-refactor-my8p0m September 2, 2022 05:56 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-params-refactor-my8p0m September 2, 2022 06:51 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-params-refactor-my8p0m September 2, 2022 06:58 Inactive
Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jorgeorpinel!

@jorgeorpinel
Copy link
Contributor Author

OK! I just don't want to merge this before #3414 is approved... ⏳

@jorgeorpinel jorgeorpinel added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Sep 7, 2022
Base automatically changed from iesahin/ug-pipelines to main September 7, 2022 22:25
@jorgeorpinel
Copy link
Contributor Author

Oops forgot to merge this before #3414 (review) 😅 Fixing... ⏳

@shcheklein shcheklein temporarily deployed to dvc-org-params-refactor-my8p0m September 7, 2022 22:36 Inactive
@jorgeorpinel jorgeorpinel merged commit 90254db into main Sep 7, 2022
@jorgeorpinel jorgeorpinel deleted the params/refactor branch September 7, 2022 22:37
@jorgeorpinel jorgeorpinel removed the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants