-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guide: updates to dvc.yaml
spec
#3789
Conversation
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
5614200
to
ef24051
Compare
@jorgeorpinel What's the status of this PR? Is it still needed? |
I'm not sure how this PR got so complicated 😓 but yes, after merging |
one change moved to #4024
0018f91
to
7e76c89
Compare
dvc.yaml
docdvc.yaml
ref
dvc.yaml
refdvc.yaml
spec
## Stage entries | ||
|
||
These are the fields that are accepted in each stage: | ||
|
||
| Field | Description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this I just moved up unchanged. It started in old line 506 before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jorgeorpinel! LGTM except confused why it says 88 commits?
It would help me better manage the docs workload if we can be a little more careful about what changes are worthwhile. If the PR was all about making it more of a spec and less of a guide it would make more sense, but most changes look like minor, subjective style issues. If we can reduce some of those, I hope it can help reduce noise and focus more on what's important. I know you don't intend for me to have to review everything right away, but it would help to cut out the unimportant stuff altogether instead of having to try to figure it out as I review the PR. 🙏
What do you think?
It's 88 commits because this was started in July. I later removed a bunch of changes. Agree about the relevance of these changes. At that time I already had a bunch of edits stashed for this file which I didn't manage to propose since they never seemed major enough so eventually I just made the PR (and then it grew out of control). But don't worry, in the new docs process, this kind of work is not something I'll be paying much attention to in the foreseeable future. |
Link Check ReportThere were no links to check! |
Extracted from #3414 (comment)
This page should focus on the schema/spec of the file and it's sections more than guidance and explaining concepts, since we'll have a guide for that now (see #3414).