params: support for tracking all params in a file
#3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Apr 8, 2022
dberenbaum
reviewed
Apr 8, 2022
dberenbaum
reviewed
Apr 8, 2022
|
Is there a syntax for |
This comment was marked as outdated.
This comment was marked as outdated.
jorgeorpinel
changed the title
params: support for tracking all params in a file
Comment on lines
54
to
61
| dependency. They consist of a list of params to track in one of these formats: | ||
|
|
||
| 1. A param key/value pair that can be found in `params.yaml` (default | ||
| params file); | ||
| 2. A dictionary named by the file path to a custom params file, and with a | ||
| list of param key/value pairs to find in it; | ||
| 3. An empty set (give no value or use `null`) named by the file path to a | ||
| params file: to track all the params in it dynamically. |
There was a problem hiding this comment.
The detail given now may be too much but we can address that... (from #3431 (review))
Well... I ended up adding even more details here. This should at some point get extracted to a separate guide (#2572) but OK to keep for now, I think.
Co-authored-by: Restyled.io <[email protected]>
Gatsby Cloud Build Reportdvc.org 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 56s PerformanceLighthouse report
|
2 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@skshetry PTAL |
daavoo
approved these changes
May 13, 2022
|
@skshetry @jorgeorpinel merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See iterative/dvc#7432.