Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp init: UX updates #3430

Merged
merged 13 commits into from
Jun 14, 2022
Merged

exp init: UX updates #3430

merged 13 commits into from
Jun 14, 2022

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Apr 8, 2022

Now, DVC generates the boilerplate structure for all the dependencies that don't already exist. Also, the output structure for prompts was changed.

@shcheklein shcheklein temporarily deployed to dvc-org-document-exp-in-xkkihi April 8, 2022 12:49 Inactive
@skshetry skshetry requested review from dberenbaum and jorgeorpinel and removed request for dberenbaum April 8, 2022 12:50
jorgeorpinel
jorgeorpinel reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committing 👇🏼

content/docs/command-reference/exp/init.md Outdated Show resolved Hide resolved
content/docs/command-reference/exp/init.md Outdated Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request Apr 12, 2022
Merged
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-document-exp-in-xkkihi April 12, 2022 04:34 Inactive
@jorgeorpinel jorgeorpinel changed the title document exp init output changes document exp init stdout changes Apr 12, 2022
@jorgeorpinel jorgeorpinel changed the title document exp init stdout changes exp init: UX updates Apr 12, 2022
jorgeorpinel added a commit that referenced this pull request Apr 12, 2022
@jorgeorpinel
ref: update exp init intro.
6f23810 
extracted from #3430 (review) (by @dberenbaum )
@jorgeorpinel jorgeorpinel mentioned this pull request Apr 12, 2022
Closed
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Apr 12, 2022 •
edited
Loading

Does https://dvc.org/doc/user-guide/experiment-management/experiments-overview#initialize-dvc-experiments-on-any-project need an update too?

@jorgeorpinel
Copy link
Contributor

I'll take this one over.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Apr 29, 2022 •
edited
Loading

Gatsby Cloud Build Report

dvc.org

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 3m

Performance

Lighthouse report

Metric Score
Performance 🔶 62
Accessibility 💚 98
Best Practices 🔶 83
SEO 💚 93

🔗 View full report

@jorgeorpinel jorgeorpinel requested a review from dberenbaum April 29, 2022 22:39
@julieg18 julieg18 temporarily deployed to dvc-org-document-exp-in-nmweie June 2, 2022 13:56 Inactive
@dberenbaum dberenbaum removed the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Jun 7, 2022
@jorgeorpinel jorgeorpinel mentioned this pull request Jun 11, 2022
Merged
@shcheklein shcheklein temporarily deployed to dvc-org-document-exp-in-nmweie June 11, 2022 20:41 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-document-exp-in-nmweie June 11, 2022 20:49 Inactive
@jorgeorpinel jorgeorpinel requested a review from dberenbaum June 11, 2022 20:51
jorgeorpinel
jorgeorpinel approved these changes Jun 11, 2022
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but WDYT @dberenbaum ? Feel free to merge.

@jorgeorpinel jorgeorpinel self-assigned this Jun 11, 2022
@shcheklein
Copy link
Member

@jorgeorpinel there are some CI checks that failed

@dberenbaum
Copy link
Contributor

LGTM but WDYT @dberenbaum ? Feel free to merge.

I saw one issue with --type=dl (which is no longer an option), but besides that and CI issues, LGTM. Thanks!

@jorgeorpinel
Copy link
Contributor

there are some CI checks that failed

There was something wrong in master. Recently fixed in #3640 -- should be fine but merging it in just in case...

@shcheklein shcheklein requested a deployment to dvc-org-document-exp-in-nmweie June 14, 2022 09:24 Abandoned
@shcheklein shcheklein temporarily deployed to dvc-org-document-exp-in-nmweie June 14, 2022 09:29 Inactive
@jorgeorpinel jorgeorpinel merged commit 761f723 into master Jun 14, 2022
@jorgeorpinel jorgeorpinel deleted the document-exp-init-changes branch June 14, 2022 09:29
@jorgeorpinel
Copy link
Contributor

one issue with --type=dl (which is no longer an option)

Then we missed a cmd ref update somewhere because it's still mentioned in a few places of https://dvc.org/doc/command-reference/exp/init

@jorgeorpinel jorgeorpinel mentioned this pull request Jun 14, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daavoo daavoo daavoo left review comments

@dberenbaum dberenbaum dberenbaum left review comments

@shcheklein shcheklein shcheklein approved these changes

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Assignees

@jorgeorpinel jorgeorpinel

@skshetry skshetry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skshetry @jorgeorpinel @shcheklein @dberenbaum @daavoo @julieg18