Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: config reads from all config files combined #3359

Merged
merged 1 commit into from
Mar 30, 2022
Merged

ref: config reads from all config files combined #3359

merged 1 commit into from
Mar 30, 2022

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel requested a review from shcheklein March 15, 2022 17:37
@jorgeorpinel jorgeorpinel self-assigned this Mar 15, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-ref-config-d3zukpo4j48 March 15, 2022 17:38 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Mar 15, 2022
Closed
@jorgeorpinel jorgeorpinel changed the title ref: mention config reads from all config files combined ref: config reads from all config files combined Mar 15, 2022
@jorgeorpinel jorgeorpinel requested a review from dberenbaum March 30, 2022 08:47
dberenbaum
dberenbaum approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems with the proposed changes. I'm not sure they do enough to address the issue or explain how config sections get merged, but maybe that's left to a future PR?

@jorgeorpinel jorgeorpinel merged commit 1debb1e into master Mar 30, 2022
@jorgeorpinel jorgeorpinel deleted the ref/config branch March 30, 2022 21:06
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Mar 30, 2022 •
edited
Loading

Thanks. Yeah we can expand on this when we address #340.

iesahin pushed a commit that referenced this pull request Apr 11, 2022
@jorgeorpinel @iesahin
ref: mention config reads from all config files combined (#3359)
34200b0 
per #1368 (comment)
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. C: ref Content of /doc/*-reference labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum approved these changes

@shcheklein shcheklein Awaiting requested review from shcheklein

Assignees

@jorgeorpinel jorgeorpinel

Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeorpinel @dberenbaum @shcheklein