guide: note that exp run commits data
#3271
Conversation
other misc edits to Running Exps
jorgeorpinel
temporarily deployed
to
dvc-org-exp-run-commit--rs7ac0
| `targets` and stage execution (restores the dependency graph, etc.). One | ||
| important difference is that changed dependencies are committed to the <abbr>DVC | ||
| cache</abbr> when the experiment begins execution, to guarantee the | ||
| reproducibility of any recorded experiment. |
There was a problem hiding this comment.
One question for this PR's reviewer(s): #2418 was about performance implications. Should this be stressed further here or in the guide?
For now I may just link to
gcand check whether that ref. mentionsexp gc(as vice versa).
There was a problem hiding this comment.
I think just noting that it is committed is fine
There was a problem hiding this comment.
See my comment in #2418 (comment). dvc repro also commits changed dependencies to the DVC cache, so I don't see a difference here.
I'm having flashbacks to our original discussion about this 😅 . I think this initially came up because dvc exp run didn't used to commit changed dependencies, but we changed it to behave more like dvc repro.
There was a problem hiding this comment.
this initially came up because dvc exp run didn't used to commit changed dependencies, but we changed it to behave more like dvc repro
Right I just went all the way back to iterative/dvc#5593, iterative/dvc#5859, and #2418 and it seems that's what the change was. So this paragraph about being different to repro is incorrect... ⌛
There was a problem hiding this comment.
OK I updated the changes... PTAL @dberenbaum
I think just noting that it is committed is fine
Yeah that's what I did now. I didn't specifically mention it in the context of queueing, just left generic language that applies to running or queueing ("when preparing the experiment").
jorgeorpinel
force-pushed
the
exp-run/commit-repro
branch
from
84dd0ca to
7b4b838
Compare
jorgeorpinel
temporarily deployed
to
dvc-org-exp-run-commit--rs7ac0
jorgeorpinel
temporarily deployed
to
dvc-org-exp-run-commit--rs7ac0
jorgeorpinel
temporarily deployed
to
dvc-org-exp-run-commit--rs7ac0
* guide: note that `exp run` commits data and other misc edits to Running Exps * ref: note that `exp run` commits dependencies * ref: udpates to `gc` ref inc. link to `exp gc` * exp run: clarify implicit implications of committing deps per #3271 (review)
and other misc edits to Running Exps, and to the
gcref.To close #2418