Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guide: update info. around dvc process locking #3251

Merged
merged 1 commit into from
Mar 30, 2022
Merged

guide: update info. around dvc process locking #3251

merged 1 commit into from
Mar 30, 2022

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Feb 2, 2022 •
edited
Loading

@jorgeorpinel jorgeorpinel self-assigned this Feb 2, 2022
@jorgeorpinel jorgeorpinel mentioned this pull request Feb 2, 2022
Closed
@shcheklein shcheklein temporarily deployed to dvc-org-dotdvc-tmp-lock-bn8s55 February 2, 2022 04:17 Inactive
@jorgeorpinel jorgeorpinel changed the title lock: update info. around locking and "parallel" dvc processes guide: update info. around dvc process locking Feb 2, 2022
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Feb 2, 2022 •
edited
Loading

@efiop @shcheklein need some help to determine a more complete description for .dvc/tmp/lock in https://dvc.org/doc/user-guide/project-structure/internal-files and perhaps an update to https://dvc.org/doc/user-guide/troubleshooting#lock-issue. Thanks

@efiop
Copy link
Contributor

efiop commented Feb 17, 2022

@jorgeorpinel Sorry for the delay. Not sure I understand what kind of description you have in mind. It is just an internal file that locks the whole repo from the user perspective.

@iesahin
Copy link
Contributor

iesahin commented Feb 22, 2022

What commands can be run with this lock in place? No commands? Some commands? @efiop

@jorgeorpinel
Copy link
Contributor Author

Not sure I understand what kind of description you have in mind

@efiop I'm trying to address #860 which is very old. I wanted to close it but we're unsure on whether some existing docs around locking behavior are current (see #860 (comment)).

What commands can be run with this lock in place?

This is also unclear to me. I think it's only used during (exp) run/repro ?

@iesahin

This comment was marked as outdated.

Sign in to view
@jorgeorpinel

This comment was marked as outdated.

Sign in to view
@jorgeorpinel jorgeorpinel marked this pull request as ready for review March 30, 2022 08:27
@iesahin iesahin merged commit b3881ee into master Mar 30, 2022
@iesahin iesahin deleted the dotdvc/tmp/lock branch March 30, 2022 14:24
iesahin pushed a commit that referenced this pull request Apr 11, 2022
@jorgeorpinel @iesahin
guide: update info. around dvc process locking (#3251)
56d5702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iesahin iesahin iesahin approved these changes

@dberenbaum dberenbaum Awaiting requested review from dberenbaum

Assignees

@jorgeorpinel jorgeorpinel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd ref: document releasing of locks in dvc run
4 participants
@jorgeorpinel @efiop @iesahin @shcheklein