ref: Add plots.auto_open in dvc.config
#3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
added
⌛ status: wait-core-merge
2 tasks
jorgeorpinel
temporarily deployed
to
dvc-org-plots-auto-open-gu4tho
Comment on lines
284
to
285
| - `plots.auto_open` - if `true`, DVC will automatically open the HTML | ||
| generated by `dvc plots` commands in a browser. `false` by default |
There was a problem hiding this comment.
Q: Will this apply to dvc exp show --html (or whatever the final command for PCPs is) ? If so maybe add a check box to update this in #3105 at some point).
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
So now that #3098 was merged first maybe we should address #3098 (review) here?
1 task
Co-authored-by: Restyled.io <[email protected]>
jorgeorpinel
temporarily deployed
to
dvc-org-plots-auto-open-gu4tho
jorgeorpinel
had a problem deploying
to
dvc-org-plots-auto-open-gu4tho
daavoo
removed
the
⌛ status: wait-core-merge
jorgeorpinel
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
@jorgeorpinel any updates? can we merge this?
Yep. I did not intend to block this merge and it's approved already. I did just leave some more suggestions but it's mergeable.
Thanks again for the contribution and addressing all the feedback too, @daavoo !
iesahin
pushed a commit
that referenced
this pull request
Apr 11, 2022
* ref: Add `plots.auto_open` in `dvc.config` * ref: copy edits around plots --open * Mention auto_open in pcp Co-authored-by: Jorge Orpinel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P.R. for iterative/dvc#7159