Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: state exp names should be unique #3065

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Conversation

jorgeorpinel
Copy link
Contributor

@shcheklein shcheklein temporarily deployed to dvc-org-ref-exp-unique--quacbd December 7, 2021 01:20 Inactive
@jorgeorpinel jorgeorpinel changed the title ref: state exp names shoold be unique ref: state exp names should be unique Dec 7, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-unique--quacbd December 7, 2021 01:21 Inactive
@jorgeorpinel
Copy link
Contributor Author

Cc @iesahin do you think we should mention in the guide or other refs as well? Or GS

@iesahin
Copy link
Contributor

iesahin commented Dec 7, 2021

Can we have an experiment naming guide somewhere? :)

@shcheklein shcheklein merged commit e680e08 into master Dec 7, 2021
@shcheklein shcheklein deleted the ref/exp/unique-name branch December 7, 2021 16:14
@jorgeorpinel
Copy link
Contributor Author

experiment naming guide somewhere

What info would you think people need guidance for @iesahin ?

See also #2909 (comment)

@jorgeorpinel jorgeorpinel self-assigned this Dec 7, 2021
@iesahin
Copy link
Contributor

iesahin commented Dec 8, 2021

I think experiment names are a minor point and the content we have already covers it, but it began to feel we better have a section in the overview for them as bullet points. Something like:

  • Experiments get their names from the content of the pipeline, unless specified by the --name option.
  • Queued experiments have a names before they run, and they get another name after running.
  • Experiment names should be unique.
  • Experiment names cannot contain /

etc.

@jorgeorpinel
Copy link
Contributor Author

@iesahin now there are some exp naming details hidden in https://dvc.org/doc/user-guide/experiment-management/experiments-overview, including that exp names should be unique and where they come from

image

It doesn't cover:

  • Experiments get their names from the content of the pipeline

Not sure what you mean by that though. The default ones are actually derived from the custom ref commit hash.

Queued experiments have a names before they run

We don't have this info anywhere rn. Do you want to add it to the hidden section in https://dvc.org/doc/user-guide/experiment-management/running-experiments#the-experiments-queue for now?

Experiment names cannot contain /

Yeah the naming rules should be the same as https://git-scm.com/docs/git-check-ref-format. Feel free to include that in the existing passage(s) as well!


The larger question is whether this info deserves to be unhidden and/or centralized. And if so where

@shcheklein
Copy link
Member

I think it can be a separate section - Naming experiments with some details around this and where those names could be used. I would even make it a top level in the UG. Even it's simple (better for it to be simple).

iesahin pushed a commit that referenced this pull request Apr 11, 2022
* ref: state exp names shoold be unique

rel. iterative/dvc#6848

* Restyled by prettier (#3066)

Co-authored-by: Restyled.io <[email protected]>

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants