Update landing page #3032
Update landing page #3032
Conversation
* adjusted texts, widths, and positioning
* increase button animation * take off video
* add image (to be changed later) * update texts * turn title into link * fix scroll bug
| </Link> | ||
| <StaticImage | ||
| alt="a description of blog image" | ||
| src="../../../../static/uploads/images/2021-10-28/oct-community-gems.png" |
There was a problem hiding this comment.
I used a old blog image for now. We need to update this to the new blog image once we have it.
There was a problem hiding this comment.
It looks good! Will the image be clickable too(link to the blog post? And I think the text font could be a bit bigger if possible. Maybe we should bold Read more too.
There was a problem hiding this comment.
It looks good! Will the image be clickable too(link to the blog post? And I think the text font could be a bit bigger if possible. Maybe we should bold Read more too.
I turned the image into a link, increased the text size, and bolded the link!
* make image a link * increase text by 2px on bigger screens * make link bold
julieg18
force-pushed
the
update-landing-page
branch
from
0fd8560 to
0394bff
Compare
|
Landing page now has proper popup designs! Once we have a video id and blog image (and if we don't find anything wrong with the current code), we should be good to merge! |
|
@julieg18 Here is the link to the video. It is currently not published. It will publish at 3am PST tomorrow morning. |
|
@julieg18 Just noticed that in the modal it has the Community Gems image. Is that just a place holder or and when Dave's blog post goes live it will fill with the cover image? Or do you need the image too? Clarifying just in case! |
It's a placeholder. I was planning to update the image as soon as Dave's post was merged to master |
Awesome! I should be awake around that time. I'll update the image and merge this to master once both the Youtube video AND blog post is available! |
| @@ -5,15 +5,24 @@ | |||
| "no-duplicate-selectors": null, | |||
| "declaration-colon-newline-after": null, | |||
| "value-list-comma-newline-after": null, | |||
| "property-no-unknown": [true, { | |||
There was a problem hiding this comment.
I'm not sure why but I was forced to run prettier on several files when I merged with master 🤔 And these several files are breaking the commit check... cc @rogermparent
There was a problem hiding this comment.
The Gatsby 4 update also updated linters alongside it, and apparently those linters either weren't as stringent or weren't running at all before the update. That said, I don't know why changes that weren't originally in this PR are getting added by Prettier, they should have been taken care of by the retroactive fixes I did in that PR.
|
When will this be merged @julieg18? |
@jendefig We can technically merge it but I had an issue with our package.json and the commit check is failing. |
* Add WhatsNewModal * Add video to hero
Fixes #2949