-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Gatsby 4 and fix images paths that broke builds #3021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julieg18 Great catch on the card collapsing! I'm not sure why that would have changed, I know the major upgrade on I just fixed it by using slightly more proper |
Not sure why Restyled is trying to change this, running |
I think I had the same issue when I tried to edit that particular file that Restyled is trying to restyle. I think it had something to do with the kind of environment that Restyled is using to run code. |
I took a check around all the top-level pages and usages of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* Upgrade packages to Gatsby 4 and fix images paths that broke builds * Update eslint and migrate from old rules * Update stylelint and fix resulting problems * Convert trends-chart color profile * Use light version of github stylesheet * Upgrade packages and configure SVGR/SVGO with external file Recommended by plugin author * Fix docs index cards styles to properly collapse * stylelint --fix * eslint --fix * Upgrade gatsby packages
I decided to use Gatsby 3 in #2447 since Gatsby 4 was still in beta, most plugins hadn't updated to match it, and it seemed to be a bit less stable in Heroku builds.
Since then, Gatsby 4 has left beta and most plugins have updated to work with it. Also, Gatsby Cloud's image processing has integrations specific to 4, so this PR will be used to test on Gatsby Cloud.
Also, it seems one of the upgrades since then has made it to that builds fail when an image path isn't found- this is a good thing, since we had a few images that were completely broken and just unnoticed, and some "phantom" images that worked when they shouldn't have.
This PR also updates the
typescript
andeslint
packages, which was required becausereact-use
uses named tuples, a feature introduced in newer TypeScript versions, and eslint needed to be upgraded alongside TypeScript.I also upgraded
stylelint
, which then discovered a whole ton of CSS problems that we had before, including obvious stuff like duplicated keys. The results ofstylelint --fix
ended up being the bulk of the PR's diff.