Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start: Pipelines trail #2919

Closed
wants to merge 7 commits into from
Closed

start: Pipelines trail #2919

wants to merge 7 commits into from

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Oct 12, 2021

This modifies start/data-pipelines for dvc stage add and a new project.

Closes #2857

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-issue28-s3ksse October 12, 2021 09:54 Inactive
@iesahin iesahin changed the title modified up to DAG section guide: Add data-pipelines trail Oct 12, 2021
@iesahin iesahin self-assigned this Oct 12, 2021
@iesahin iesahin changed the title guide: Add data-pipelines trail start: Pipelines trail Oct 12, 2021
@shcheklein
Copy link
Member

Let's discuss first the detail in the #2857. Also, in terms of the priorities - I would say, we need to wrap up the experiments trail first.

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-issue28-s3ksse October 19, 2021 09:43 Inactive
@iesahin
Copy link
Contributor Author

iesahin commented Oct 19, 2021

I modified this one not to use example-dvc-experiments, but example-get-started again. It currently uses only stage add but doesn't tell anything about running the pipeline. Which command is more appropriate here, dvc exp run or dvc repro? @shcheklein @dberenbaum

@dberenbaum
Copy link
Contributor

dberenbaum commented Oct 21, 2021

For getting started, I would probably focus on exp run since it's already being introduced for experiments and may be more useful for the typical use case here. However, I do think there are situations where people may prefer repro, so we probably want to mention it briefly here and/or in more detail in the user guide.

I don't have a strong opinion, so interested to hear your thoughts.

@iesahin
Copy link
Contributor Author

iesahin commented Oct 21, 2021

It may be better to provide a pipelines document without going into (a) metrics and plots (b) multiple stages.

@iesahin
Copy link
Contributor Author

iesahin commented Oct 21, 2021

As we split stage definition and running them, the flow of text will also change.

@iesahin
Copy link
Contributor Author

iesahin commented Oct 21, 2021

I think having two "under the hood" sections is unnecessary.

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-issue28-s3ksse October 21, 2021 17:17 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-issue28-s3ksse October 23, 2021 17:06 Inactive
@iesahin
Copy link
Contributor Author

iesahin commented Oct 23, 2021

@dberenbaum
Copy link
Contributor

At a quick glance, I think the discussion points make sense, although I wouldn't keep all examples in the ML/DS context.

@rogermparent rogermparent temporarily deployed to dvc-org-iesahin-issue28-s3ksse October 25, 2021 16:24 Inactive
@iesahin iesahin closed this Nov 1, 2021
@iesahin
Copy link
Contributor Author

iesahin commented Nov 1, 2021

Moved this to Notion

@rogermparent rogermparent deleted the iesahin/issue2857 branch November 3, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

start: Pipelines Trail
4 participants