Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guide: DVC Experiments Overview #2909
guide: DVC Experiments Overview #2909
Changes from 3 commits
5e43591
6b7300a
6027e15
7704a4d
8f04899
3bfd2a9
0c2bcf5
27afdc1
30db819
aa3c5d0
7710433
a133f70
32a269f
af94248
dacaf85
cab14da
9a1e142
b40f340
73175a9
112ad87
9c2a55c
9b2902a
7b9384f
c9493f4
42454f0
bd95136
6162f5a
63a9864
5043e64
27f01e6
a799743
59505f6
3d0bede
db2d610
f6eef79
c68fc78
3384af0
9fd3b3a
f241901
e122b0a
659dd82
73d510d
9d43ca6
24c967d
439050e
3af2f9a
12f8797
ad652a6
8aed622
c088a06
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"cause different behaviors" -> "may modify the results" or something softer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to "simple values in a formatted text file which you can tweak and use in your code". WDYT @iesahin ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From #2654 (review)
@shcheklein maybe, let's decide... But not in scope for this PR probably?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
dvc exp
commands work towards this organization pattern, not separate directories. IMO we can modify this section to describe the organization pattern DVC leads. We don't have much facility to use "space dimension" for experiments.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This index tries to cover the traditional experiments as well. It's not exclusively about
dvc exp
until you get to the sub-pages. That's one of the reasons for creating a separate DVC Experiments overview page in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I look into the text, I think DVC helps to organize the experiments in "space dimension" as well. What DVC does is better IMO, but mentioning these organization patterns seems to remind the reader a feature DVC lacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to improve on this indeed so it's clear that we're separating manual exp tracking you can do on DVC projects vs. the DVC Experiments workflow.UPDATE: Wait I was confusing this discussion with #2909 (review)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can @iesahin, for example multiple via
dvc.yaml
files (copy/pasted + small changes) or viainit --subrepo
(monorepo structure). Both supported by DVCThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. this makes me thing about another route: using
foreach
stages to quickly define multiple experiments based on a params file and running them all (in parallel). I guess it's a pre-exp
way to manage experiments with DVC, but in which you can see all the results at once in your workspace (may be messy unless you create a bunch of subdirectories so perhaps it's the same as the "space dimension")...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.p.s I added a section about custom labels as well (for org pattern) based on this table. See c68fc78
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
dvc exp
workflow is orthogonal to these features, they are not alternatives to each other. One can use multipledvc.yaml
files withdvc exp
as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are conceptual alternatives which you can combine, which is already stated in the text.