Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment-management: remove warning about no parameter validation #2824

Merged
merged 8 commits into from
Oct 20, 2021

Conversation

mattlbeck
Copy link
Contributor

@mattlbeck mattlbeck commented Sep 13, 2021

Per iterative/dvc#6521

Covers feature change iterative/dvc#6521. Parameters will now be validated.

Related issue iterative/dvc#5477

Covers feature change iterative/dvc#6521. Parameters will now be validated.

Related issue iterative/dvc#5477
@mattlbeck
Copy link
Contributor Author

This simply removes the warning about lack of parameter validation at the moment.

@dberenbaum
Copy link
Contributor

Do you mind marking this as a draft until iterative/dvc#5477 is merged?

@daavoo daavoo added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Sep 13, 2021
@jorgeorpinel jorgeorpinel marked this pull request as draft September 13, 2021 16:26
jorgeorpinel
jorgeorpinel previously approved these changes Sep 13, 2021
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's all we need here actually so I'll make it a regular PR and just label it. Thanks @mattlbeck

@jorgeorpinel jorgeorpinel marked this pull request as ready for review September 13, 2021 16:29
@jorgeorpinel jorgeorpinel dismissed their stale review October 15, 2021 01:24

Actually...

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good but we need a few other changes:

Thanks

@mattlbeck
Copy link
Contributor Author

* Optinally/Additionally, the sample command block under that same text could have `dvc param list` and it's output (showing `model.learning_rate` among 1-2 other params) before the `exp run --set-param model.learning_rate` command).

@jorgeorpinel unless I am missing something dvc param list doesn't exist. As an alternative we could demonstrate with a cat params.yaml?

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 20, 2021

we could demonstrate with a cat params.yaml?

Yes @mattlbeck sorry, I made up a command haha. I applied your idea. The last 2 check boxes in #2824 (review) are still pending.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, I see everything is addressed. Thanks again @mattlbeck !

@jorgeorpinel
Copy link
Contributor

I merged #2944 but this is still open 🤔 and now has more conflicts...

@jorgeorpinel
Copy link
Contributor

merged #2944 but this is still open

I think Restyled is having some issues (again)... After merging it to master, this PR showed conflicts with the formatted bits (should've been closed by that). And now that I solved the conflicts (used master versions) it created another PR with 0 changes (how do you even do that?): #2945

@jorgeorpinel
Copy link
Contributor

how do you even do that?

My master merge wasn't correct -- left an accidental trailing space in there. The Restyled PR changed it back to the already merged version in master. (That's how.)

Now I fixed the formatting here and there are no changes in this PR... 🤷 merging!

@jorgeorpinel jorgeorpinel merged commit b818676 into iterative:master Oct 20, 2021
@mattlbeck mattlbeck deleted the exp-run-validate-params branch October 21, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌛ status: wait-core-merge Waiting for related product PR merge/release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants