Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --show-csv flag to dvc exp show #2740

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Add --show-csv flag to dvc exp show #2740

merged 3 commits into from
Sep 29, 2021

Conversation

karajan1001
Copy link
Contributor

@karajan1001 karajan1001 commented Aug 23, 2021 •
edited by jorgeorpinel
Loading

@karajan1001

This comment has been minimized.

Sign in to view
@karajan1001 karajan1001 marked this pull request as draft August 23, 2021 09:19
@jorgeorpinel

This comment has been minimized.

Sign in to view
@karajan1001

This comment has been minimized.

Sign in to view
@shcheklein

This comment has been minimized.

Sign in to view
@karajan1001 karajan1001 marked this pull request as ready for review September 9, 2021 08:17
@karajan1001
Copy link
Contributor Author

As the core PR been merged, we can work on this one now.
Need an example? but the --show-json flag don't have an example either.

@shcheklein
Copy link
Member

Let's fix the linters and merge. If you have time it would be nice to add some example (no need to make them reproducible, etc), but I don't this is a requirement to be honest.

What would be great is to actually describe the possible use case for this and show an example for that - DS produces this in CSV and process then somewhere. It might be even beneficial to expand in the option description (cc @dberenbaum )

@dberenbaum
Copy link
Contributor

Agree that we can merge once linters are fixed!

I'm not sure about needing a usage description or example. I don't see much harm, but it seems self-evident to me: viewing the table in Excel, reading into Pandas for sorting/filtering, etc. As far as an example, we could make up one like read into pandas and filter to only experiments above a certain metric threshold, but it seems obvious and outside the scope of dvc. I think any data scientist would get it as soon as they see "csv." @karajan1001 might have good insight here also.

@jorgeorpinel jorgeorpinel mentioned this pull request Sep 9, 2021
Merged
2 tasks
@jorgeorpinel
Copy link
Contributor

Need an example? but the --show-json flag don't have an example either.

Adding a quick example that includes both would be nice if you can come up with it very quickly. Don't worry about it otherwise (cc @iesahin maybe you want to include that in #2752)

@karajan1001 also please try to use branches directly on this repo instead of a fork, so it's easier for us to contribute e.g. if I want to fix the formatting so the checks pass I have to add your fork, fetch that one branch, etc. Thanks

@jorgeorpinel
Copy link
Contributor

p.s. for this one if you just merge master now, Restyled should work again and that will fix the formatting automatically (in a separate PR that we can merge).

@dberenbaum
Copy link
Contributor

Thinking about the examples some more, I would prefer example outputs for both --show-json and --show-csv over a usage example, since what would be less obvious to users is the format of those JSON and CSV outputs, particularly since they are pretty different from one another.

@iesahin
Copy link
Contributor

iesahin commented Sep 28, 2021

I'll add an example with jq to the UG after testing it. No need to add it to the ref I believe. Thank you @karajan1001

@iesahin iesahin mentioned this pull request Sep 28, 2021
Closed
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Sep 28, 2021 •
edited
Loading

@karajan1001 please just merge master for now. We'll figure out the examples separately. Thanks

@restyled-io restyled-io bot mentioned this pull request Sep 29, 2021
Closed
jorgeorpinel
jorgeorpinel approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make an issue about the examples discussed. Thanks!

UPDATE: Already in #2860

@jorgeorpinel jorgeorpinel merged commit f35cdcd into iterative:master Sep 29, 2021
rogermparent pushed a commit that referenced this pull request Sep 30, 2021
@karajan1001 @jorgeorpinel @rogermparent
Add --show-csv flag to dvc exp show (#2740)
e6d9cac 
* Add --show-csv flag to dvc exp show

* Apply suggestions from code review

* Format problem

Co-authored-by: Jorge Orpinel <[email protected]>
rogermparent added a commit that referenced this pull request Oct 19, 2021
@rogermparent @julieg18
@daavoo @github-actions @efiop @jorgeorpinel @restyled-io @restyled-commits @jendefig @shcheklein @josecelano @GavinMasterson @iesahin @isidentical @casperdcl @karajan1001
Upgrade to Gatsby 3 and fix Heroku caching (#2851)
3b3b52d 
* Add tbd comment to pages/404.tsx

* Add comment to 404 page

* Update gatsby 2 to 3
* update needed dependencies to get gatsby 3 working
* add gatsby-plugin-image

* Update gatsby-source-github-api

* Take off tbd comment in 404.tsx

* Delete unneeded file in .github/workflows

* Fix attempted imported css warnings

* Add tbd comment to 404.tsx

* Rollback [email protected] to 3.6.0

* Remove comment in 404 page

* Move gatsby pkg back to 3.10.2

* Add tbd comment in 404 page

* Update outdated packages

* Delete tbd comment in 404 page

* Place console.log in DefaultSEO

* Run 'yarn upgrade'

* Delete comment in 404.tsx

* Upgrade @reach/portal

* Delete console.log in DefaultSeo

* Update @react/portal

* Upgrade some packages

* Update some packages

* Add tbd comment in 404.tsx

* Delete tbd comment

* Test static query

* Refactor useGlossary hook

* Move gatsby to 3.9.0

* Add tbd comment

* Update gatsby to 3.8.0

* Delete comment in 404 page

* Move gatsby to 3.6.0

* Add tbd comment

* Move gatsby to 3.4.0

* Delete comment in 404 page

* Move gatsby to 3.2.0

* Add tbd comment in 404 page

* Delete comment in 404 page

* Move gatsby to 3.0.0

* Add tbd comment in 404 page

* Update gatsby to 2.32.12

* Add tbd comment in 404 page

* Update gatsby to 3.14.0

* Move gatsby to 3.10.2

* Delete and recreate yarn.lock

* Delete tbd comment

* Update typescript to 4.4.2

* Update package.json and yarn.lock to match 1be35ce

* Add tbd comment

* Delete test query from siteMeta

* Delete console.log in siteMeta.ts

* Remove resolutions from package.json

* Delete tbd comment

* Upgrade gatsby

* Revert "Test static query"

This reverts commit 51a6012.

* Add PQR flag

* Upgrade gatsby-*-sharp and add lmdb-store

* Remove picture.small

* Update to node 16

* Add tbd comment

* Move gatsby to ^3.11.0

* Delete tbd comment

* Move gatsby to ^3.12.0

* Delete tbd comment

* Move gatsby to ^3.13.0

* Update some more packages

* Add dummy post

* Add ability to disable build retry in DEPLOY_OPTIONS

* Change content

* Change content

* Remove deprecated gatsby-image

* Try consecutive builds

* Undo consecutive builds experiment

* Log env

* Change content even more

* Remove dummy page

* Remove env display

* Add dummy page again

* Make an interim deploy script

* chmod +x

* Use vars and add test echos

* Remove echos and debug with which

* More debugging

* Even more debugging

* Remove debug stuff and mkdir that caused issues

* update content

* Remove dummy post

* Remove dummy blog post

* DVCLive User Guide updates (#2814)

* Updated top-level index. Refactored user-guide to top level

* Updated links

* Added dvclive-html.gif

* Explicit mention to automatic html update

* dvc 2.7.2 (#2813)

* dvc 2.7.2

* gha: update: delay by 2 hours

Co-authored-by: efiop <[email protected]>
Co-authored-by: Ruslan Kuprieiev <[email protected]>

* Fix broken dvc downlaod link check (#2820)

* config: sync local/CI Prettier and Restyled (#2774)

* test: change content/docs/user-guide/contributing/blog.md
for #2641

* test: bad change to .../contributing/blog.md

* test: try reverting 2dd2e91#diff-eb41540235b5687201bb19ed968c284453eea68563f5908a6e15ed8cbfa959de

* format .restyled.yaml

* config: sort prettier settings by abc

* test: expanded Restyled config file
per #2774 (comment)

* Restyled by prettier (#2775)

Co-authored-by: Restyled.io <[email protected]>

* guide: roll back dummy changes (fixes formatting)

* resyled: add comment on matching path pattern
per #2774 (review)

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>

* Added `Invalid authentication for Git Remote` to troubleshooting (#2731)

* Added note about [SSH Git URLs] in dvc exp commands

* Applied suggestions

* Updated warning

* Removed SSH from synopsis

* Added Invalid authentication for Git Remote to troubleshooting

* Added shorter title

* Applied P.R. suggestions

* Update content/docs/user-guide/troubleshooting.md

* Update content/docs/user-guide/troubleshooting.md

* Apply suggestions from code review

Co-authored-by: Jorge Orpinel <[email protected]>

* valid -> authenticated

* Format

* Update troubleshooting.md

* Removed authenticated

* Added note about git credentials

Co-authored-by: Jorge Orpinel <[email protected]>

* dvc 2.7.3 (#2829)

Co-authored-by: efiop <[email protected]>

* gha: update: run every day at 13:00 UTC

* adding sept heartbeat (#2825)

* adding sept heartbeat

* punctuation, links, code revisions

* Update content/blog/2021-09-14-september-21-dvc-heartbeat.md

* adding cover image

* corrections to description

* fix the uploaded file link

Co-authored-by: David de la Iglesia Castro <[email protected]>
Co-authored-by: rogermparent <[email protected]>
Co-authored-by: Ivan Shcheklein <[email protected]>

* Fix broken link to Azure authentication examples (#2830)

This link should point to: https://dvc.org/doc/command-reference/remote/modify#example-some-azure-authentication-methods

* gha: update download links at 18:00

* dvc 2.7.4 (#2837)

Co-authored-by: efiop <[email protected]>

* fix: correct argument order (#2842)

The order of arguments for `dvc remote rename` is reversed in the old version. 
According to the page @ `dvc remote rename -h`, the old remote `name` comes first followed by the `new` remote name argument.

* Rename all references to `get-started-experiments` to `example-dvc-experiments` (#2817)

Fixes #2784

* updating events page (#2847)

* Refactor post by Batuhan (#2835)

Co-authored-by: Batuhan Taskaya <[email protected]>
Co-authored-by: Casper da Costa-Luis <[email protected]>

* Add --show-csv flag to dvc exp show (#2740)

* Add --show-csv flag to dvc exp show

* Apply suggestions from code review

* Format problem

Co-authored-by: Jorge Orpinel <[email protected]>

* use folded block scalar type (#2871)

* Revert some unnecessary changes

* Some minor/patch package upgrades

* Add bug mitigation

* Disable PQR and bug mitigation

* Add USE_PRODUCTION_CACHE to deploy script for debugging

* Revert style import change and undo malformed comment

* Allow LayoutAlert to be false in typedef

* Remove nonstandard space and use width for spacing for lint-css

* Remove commented-out classnames

* Upgrade gatsby and some other minor/patch upgrades

* Add aptfile

* Revert "Remove commented-out classnames"

This reverts commit edae234.

* Gatsby 4 again

* Remove explicit typescript plugin and upgrade some packages

* Remove unused wrapper class

* Upgrade a bunch of packages

* upgrade plugin-feed, downgrade transformer-remark

* Update some more packages and try container stack

* Update some other packages to trigger a cache clear

* Revert stack change attempt, async setPageContext, remove Aptfile

* Upgrade CircleCI node and un-refactor glossary query

* Resolve ts-lint issues

* Prettier on content/docs/user-guide/contributing/blog.md

* Upgrade packages

* Remove composes from

* Remove source-github-api and other uses of deprecated runQuery

* Back to Gatsby 3

* Remove explicit webpack

* Use blur placeholder by default

* Fix misconfig on blur

* Upgrade some packages and remove unused lmdb-store

* yarn upgrade (lockfile only)

* Re-add typescript plugin definition (but not package.json)

* Re-add node_modules cacheDirectories

Co-authored-by: julieg18 <[email protected]>
Co-authored-by: Julie <[email protected]>
Co-authored-by: David de la Iglesia Castro <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: efiop <[email protected]>
Co-authored-by: Ruslan Kuprieiev <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Jenifer De Figueiredo <[email protected]>
Co-authored-by: Ivan Shcheklein <[email protected]>
Co-authored-by: Jose Celano <[email protected]>
Co-authored-by: Gavin Masterson <[email protected]>
Co-authored-by: Emre Sahin <[email protected]>
Co-authored-by: Batuhan Taskaya <[email protected]>
Co-authored-by: Casper da Costa-Luis <[email protected]>
Co-authored-by: Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein left review comments

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Assignees

@karajan1001 karajan1001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karajan1001 @jorgeorpinel @shcheklein @dberenbaum @iesahin