Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

studio: further enhancements #2510

Merged
merged 18 commits into from
Jun 2, 2021
Merged

studio: further enhancements #2510

merged 18 commits into from
Jun 2, 2021

Conversation

tapadipti
Copy link
Contributor

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 May 28, 2021 10:19 Inactive
@tapadipti tapadipti linked an issue May 28, 2021 that may be closed by this pull request
10 tasks
@tapadipti tapadipti mentioned this pull request May 28, 2021
10 tasks
Copy link
Contributor

@duijf duijf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting the GitHub app stuff @tapadipti! Looks good to me!

I have added two suggestions for things that we could mention in addition.

content/docs/studio/create-view.md Show resolved Hide resolved
@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 May 28, 2021 11:52 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 May 28, 2021 12:02 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 June 1, 2021 11:28 Inactive
@@ -0,0 +1,92 @@
# Additional Settings for a View
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shcheklein This is the page where I think it will be good to lead the users in case of non-dvc-repo errors. This page describes the different ways they can prepare their repo for viewing in Studio, and has a link to the DVC doc. Let me know what you think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's complicated still, but it's fine to start here. Later we could use a page similar to this https://dvc-org-studio-docs-v2-kfehbw2.herokuapp.com/doc/user-guide/troubleshooting

And a mechanism with redirects - https://error.dvc.org/lock-issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to #2515

to the sub-directory that contains the DVC repo for which you want to create
the view.

- **Data remotes:** If you need to set up DVC data remotes for your view, you
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shcheklein Let me know if you think we need to add more details regarding data remotes setup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great to mention:

  • we dont't read/access data
  • we use it only to read plots/metrics files if they are not saved into Git. And people should use it only if they have this situation. They will see a specific message in their View.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this: "Note that DVC Studio uses the credentials only to read plots/metrics files if they are not saved into Git. It does not access any other data in your remote storage. And you do not need to provide the credentials if any DVC data remote in not used in your Git repository."

@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 June 1, 2021 11:41 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 June 1, 2021 12:33 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 June 1, 2021 13:17 Inactive
@casperdcl casperdcl changed the title Further enhancements to Studio docs as per #2468 studio: further enhancements Jun 1, 2021
content/docs/start/index.md Show resolved Hide resolved
content/docs/studio/create-view.md Outdated Show resolved Hide resolved
content/docs/studio/create-view.md Outdated Show resolved Hide resolved
content/docs/studio/create-view.md Show resolved Hide resolved
content/docs/studio/create-view.md Outdated Show resolved Hide resolved
content/docs/studio/view-settings.md Outdated Show resolved Hide resolved
content/docs/studio/view-settings.md Outdated Show resolved Hide resolved
content/docs/studio/view-settings.md Outdated Show resolved Hide resolved
content/docs/studio/view-settings.md Outdated Show resolved Hide resolved
<span role="img" aria-label="shield">
🛡
<span role="img" aria-label="studio">
<img src="img/studio-icon.svg" alt=""></img>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this needs to be className from styled.module.css or even an SVG ReactComponent CC @julieg18 @rogermparent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to #2515 for fixing if needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it looks like this works totally fine, the first iteration of this alert bar did use a ReactComponent import to display a GitHub icon svg- everything else has been emojis/unicode IIRC.

An SVGR ReactComponent import seems like it would be more optimal, the difference is probably negligible to the point where is ReactComponent causes any problems (like with colors, for example, which didn't come into play on the GH svg), it's fine to stick with img.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogermparent There was some issue when we used img. We were getting Cloudflare alert that the page was offline. It was not breaking all the time, but Ivan noticed it when he was trying to load the page. We replaced the svg img with 🚀 in this PR and the alerts went away (page stopped breaking). Any idea why that may have happened and how we can use images if needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tapadipti let's please create a proper issue/bug with the screenshot, what we have done to fix, etc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Casper da Costa-Luis <[email protected]>
@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 June 1, 2021 18:02 Inactive
@tapadipti tapadipti requested a review from casperdcl June 1, 2021 18:05
@tapadipti
Copy link
Contributor Author

@casperdcl thanks for your review. I've addressed your comments, and created a new ticket with pending issues. #2515

@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 June 1, 2021 18:17 Inactive
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock merge (follow-up #2515)

@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 June 1, 2021 18:55 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 June 2, 2021 02:44 Inactive
The following video provides you a quick overview of DVC Studio.

https://www.youtube.com/watch?v=hKf4twg832g

## What is a view?

A _view_ is an interactive representation of the experiments run in your ML
project. DVC Studio automatically identifies datasets, metrics and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think automatically is not the best term here. It doesn't do anything automatically. It parses Git history and specific metafiles (or files you show to it). Automatically sounds like some magic is happening.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"intelligently?"

@@ -1,31 +1,38 @@
# Get Started with DVC Studio

Here, we will walk you through a tutorial to use DVC Studio for collaboration on
your ML projects. You will need access to a Github, Gitlab or Bitbucket account
your ML projects. You will need access to a GitHub, GitLab or Bitbucket account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the "DVC Studio creates views" view is not defined yet. Better to use some human readable terms - e.g. table with experiments? etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add a link from 'views' to the 'What is a view?' section on that page. Works?

required data (more on this later). Using this data, DVC Studio creates a
summary view. This includes tables of all the metrics across all your
experiments. You can also generate plots and compare experiments here.
hyperparameters in your ML experiments. The data can either be in DVC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data has a very specific meaning in ML, here the use of data is misleading

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing 'The data' to 'These details'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check other places

how about Values ...?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This info?"

hyperparameters) are stored in your Git repositories as CSV, JSON or YAML files.
You can add these details to your Git repositories in two ways:

1. **Set up DVC repositories**: You can use [DVC](https://dvc.org/) and Git to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DVC is not only about not bloating Git repo. It's about pipelines, connecting then with CML, etc. We should be explaining these benefits better I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a separate section/paragraph on DVC and its benefits, and link it to the DVC doc. For now, I'm adding this to the current paragraph: "DVC also
enables you to
share your data and model files,
create data registries,
create data pipelines, connect them with
CML for CI/CD in machine learning, and so on. Find more about the
features and benefits of DVC here."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we should zoom out and summarize high level benefits here (e.g. pipelines == reproducibility).

One way can be - DVC goes beyond that. It lets you organize your project in a reproducible way, it gives you way to save your experiments holistically as Git commits - data, models, metrics, params ... You could use it to organize manage your data using Git flow (data registries) ...

something like this ...

@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 June 2, 2021 05:11 Inactive
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, so that it can be merge before the release

@shcheklein shcheklein temporarily deployed to dvc-org-studio-docs-v2-kfehbw2 June 2, 2021 05:23 Inactive
@tapadipti tapadipti merged commit 554b56e into master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Studio: further enhancements
7 participants