-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: clarifications to exp run
#2368
Conversation
The results of the last experiment can be seen in the <abbr>workspace</abbr>. To | ||
display and compare your experiments, use `dvc exp show` or `dvc exp diff`. Use | ||
The results of the last experiment can be seen in the workspace. To display and | ||
compare your experiments, use `dvc exp show` or `dvc exp diff`. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should document that all of the other DVC diff commands and plots commands can also be used with experiments here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd wait to see if all the show
and diff
commands get merged 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unification of the show
and diff
commands is something that probably won't happen for a decent amount of time, and I brought it up because I have seen questions from users in discord asking about how to use plots with experiments.
either way it's not a big deal I guess
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DVC diff commands and plots commands can also be used with experiments here
Wait. But we mean more like show and compare MANY/ALL experiments here. metrics/params diff
only take 2 revs and in those cases exp diff
is prob better/easier anyway.
This only really applies to plots diff
as of now, I think? Mentioned just that in 29004e6 for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that approach makes sense @jorgeorpinel.
- Alternatively (or additionally), we could say something like "any dvc command that accepts Git revisions also accepts experiment names."
cc6fbaf
to
31e81c1
Compare
7957474
to
12ae65d
Compare
12ae65d
to
c389ca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that "in the background" doesn't seem quite right since temp experiments are blocking once they are run. Otherwise looks good, and I can take one more look once that issue is resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more Qs @pmrowla 👇 Thanks!
Use `dvc exp run --run-all` to process the queue. This is done outside your | ||
<abbr>workspace</abbr> (in a temporary dir in `.dvc/tmp/exps`), so you can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are exp queues always processed outside the workspace, even with -j 1
? And why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, "queueing" means setting up an experiment for future execution. To do that, I would expect to add to the queue, then keep making changes to my workspace without impacting the experiment that I already queued. It seems like this workflow would always require processing outside the workspace, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this workflow would always require processing outside the workspace
At exp run --run-all
it could checkout the workspace locally at each queue time, overwriting whatever you have there and forcing you to wait for it to finish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overwriting whatever you have there
It could do that, but overwriting the workspace isn't ideal, right? I know the current solution isn't perfect either, but avoiding having to overwrite the workspace seems like a big reason why exp queues are always processed outside the workspace (in addition to consistency with parallel execution and possibly remote scenarios in the future).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, I agree! I'm just saying it's not necessarily obvious, so we should be explicit about the behavior I think. I guess you were just answering the Q (with a yes). Updated a bit in d8acecb anyway. LGTM!
--temp
isn't useful yetis useful background-ing long experiments (exp run: checks out data dependencies (destructive) [QA] dvc#5593 (comment))