Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: exp-related updates in other to cmds, etc. #2242

Merged
merged 16 commits into from
Mar 15, 2021
Merged

ref: exp-related updates in other to cmds, etc. #2242

merged 16 commits into from
Mar 15, 2021

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Feb 26, 2021 •
edited
Loading

Matches certain changes in #2200 and #2243 (mainly for consistency in terminology, structure, etc.).

@shcheklein shcheklein temporarily deployed to dvc-org-ref-exp-rel-r99azihdvi February 26, 2021 07:13 Inactive
@jorgeorpinel jorgeorpinel changed the base branch from master to ref/exp/main February 26, 2021 07:13
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-rel-r99azihdvi February 26, 2021 18:56 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-rel-r99azihdvi March 1, 2021 01:32 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-rel-r99azihdvi March 1, 2021 06:58 Inactive
@jorgeorpinel jorgeorpinel changed the base branch from ref/exp/main to ref/exp/all March 2, 2021 07:16
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-rel-r99azihdvi March 2, 2021 07:18 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-rel-r99azihdvi March 2, 2021 17:40 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-rel-r99azihdvi March 3, 2021 07:15 Inactive
@jorgeorpinel jorgeorpinel changed the title ref: updates to cmds other than exp but related to exp cmd refs text ref: exp-related updates in other to cmds Mar 3, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-ref-exp-rel-r99azihdvi March 3, 2021 09:45 Inactive
@jorgeorpinel jorgeorpinel changed the title ref: exp-related updates in other to cmds ref: exp-related updates in other to cmds, etc. Mar 10, 2021
@jorgeorpinel jorgeorpinel changed the base branch from ref/exp/all to master March 10, 2021 20:59
@jorgeorpinel jorgeorpinel mentioned this pull request Mar 10, 2021
Closed
@jorgeorpinel jorgeorpinel requested a review from shcheklein March 10, 2021 21:15
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Mar 13, 2021 •
edited
Loading

Need a review/approval pls 🙂

jorgeorpinel
jorgeorpinel commented Mar 14, 2021
View reviewed changes
content/docs/command-reference/repro.md Outdated
Comment on lines 182 to 185
- `--pull` - [pulls](/doc/command-reference/pull) dependencies and outputs
involved in the stages being reproduced, if they are found in the
[default remote storage](/doc/command-reference/remote/default). Note that it
tries the local run-cache first (unless `--no-run-cache` is also used).
- `--pull` - downloads dependencies and outputs in the stages being reproduced
from the [default remote storage](/doc/command-reference/remote/default) (see
`dvc pull`) based on the run-cache. Note that this doesn't include initial
pipeline data sources (never found in the run-cache).

This comment was marked as resolved.

Sign in to view

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Mar 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. it's a kind of confusing option. Why is --pull specifically related to run-cache? 🤷 But anyway, when iterative/dvc/issues/4742 is addressed, that should be taken care of.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely just because the original request was just for a method to pull run-cache+outputs for specific (run-cached) stages: iterative/dvc#4223

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably not use dependencies here at all. Maybe just say something like this?
[pulls](...) outputs for any stages which restored from [run-cache](/doc/user-guide/experiment-management#automatic-log-of-stage-runs-run-cache) during pipeline reproduction. Outputs will be pulled from the [default remote storage](...).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Updated 👍

@jorgeorpinel jorgeorpinel mentioned this pull request Mar 14, 2021
Closed
pmrowla
pmrowla approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@pmrowla pmrowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeorpinel jorgeorpinel merged commit 1ea1c18 into master Mar 15, 2021
@jorgeorpinel jorgeorpinel deleted the ref/exp/rel branch March 19, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrowla pmrowla pmrowla approved these changes

@shcheklein shcheklein Awaiting requested review from shcheklein

@dberenbaum dberenbaum Awaiting requested review from dberenbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeorpinel @pmrowla @shcheklein