Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glossary: create "stage" entry #2198

Closed
wants to merge 47 commits into from
Closed

glossary: create "stage" entry #2198

wants to merge 47 commits into from

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Feb 16, 2021

This adds a BC document for stage. It also contains tooltip: front matter to fix #1579

TODO

  • Resolve whether a stage runs an experiment here
  • Resolve whether to mention invalidation here

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-issue15-1c4g1u February 16, 2021 18:23 Inactive
@iesahin
Copy link
Contributor Author

iesahin commented Feb 16, 2021

This is also related with #550

match: ['stage', 'stages']
tooltip: >-
A stage is a single unit of execution in a pipeline that produces some
(intermediate or final) output. [📖](/doc/user-guide/concepts/stage)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

�?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the current version of the tooltip? sorry, I'm lost a bit - have we migrated all of the to the new format or it's still in progress?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is tooltip for stage as of now. That sign was a link with a text of 📖 (like 📖 ) but why was it corrupted, I don't get.

Updating the text and removing icon.


# Stage

A stage is a single unit of execution in a <abbr>pipeline</abbr> that takes some
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go a bit more informal here? To be extreme: "Stage is any command that you would usually run from CLI that usually reads some files and produces other files or models. It can be something as simple as `python train.py " ...

We want here to give people sense about these things, I think. Using regular language, simple examples. Something that would make it very easy to catch the idea ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1ea2da3 is better in that regard. Thank you.

@iesahin
Copy link
Contributor Author

iesahin commented Feb 17, 2021

Like "a stage is a step in an experiment/pipeline that may import a file, runs an experiment, etc."?

isidentical and others added 2 commits February 17, 2021 16:03
* cmd: add dvc update --to-remote docs

* Update content/docs/command-reference/update.md

Co-authored-by: Jorge Orpinel <[email protected]>

Co-authored-by: Ivan Shcheklein <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
* Draft of Feb Heartbeat

* please work

* add images

* fix HB image and author path

* typos and spacy pic change

* typos

* updates to Heartbeat

* revised dagshub image and link

* images shrunk

* dashub-logo

* corrcting Roger and Dagshub logo

* adjust roger

* added Alt text

* cleanup: delete redundant files

* Update 2021-02-12-february-21-dvc-heartbeat.md

* Delete 2021-02-12-february-21-dvc-heartbeat.md

* Update jeny_defigueiredo.md

* Update jeny_defigueiredo.md

* Delete spacy_integration.png

* Delete dags_diagram.png

Co-authored-by: elleobrien <[email protected]>
Co-authored-by: Ivan Shcheklein <[email protected]>
@iesahin
Copy link
Contributor Author

iesahin commented Feb 18, 2021

This contained a BC document for the stage but I deleted it after your suggestion to have rather an informal language. It doesn't change anything on the sidebar. @shcheklein

Comment on lines 5 to 7
A single step in a pipeline which may import data, run experiments and produce
some (intermediate or final) output. Stages may depend other stages and they
can be automatically invalidated when their dependencies change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. I'd look in https://dvc.org/doc/command-reference/run for the existing definition/explanation. Specific questions on this current text:

  • Stages run experiments? I think not exactly
  • Probably need to describe "invalidated"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A user runs experiments in stages and a stage may be completely about running an experiment, right? Am I missing something? Stages don't run experiment but a stage may only be about running an experiment.

Will add a "user" there.

Instead of invalidation, I can tell how run or repro skips some stages but succinctly using the "invalidation" seemed more appropriate.

Copy link
Contributor

@jorgeorpinel jorgeorpinel Feb 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experiments are broader than individual stages (see WIP https://dvc-org-guide-experimen-xigcev.herokuapp.com/doc/user-guide/experiment-management). For now I think there's no need to complicate this tooltip with the concept of experiments.

Instead of invalidation, I can tell how run or repro skips some stages

Check the "parameter" and "pipelines file" tooltips: they use invalid (considered outdated)

dmpetrov and others added 13 commits February 18, 2021 01:19
* document stage:add

* fix typos, indent flags in usage, add tooltip

* add syntax highlighting for stage:add command

* minor fixup

* Update content/docs/command-reference/stage/add.md

* Update content/docs/command-reference/stage/add.md

* Apply suggestions from code review from @jorgeorpinel

Co-authored-by: Jorge Orpinel <[email protected]>

* indent examples

* put command details before dependencies and outputs section

Co-authored-by: Jorge Orpinel <[email protected]>
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-issue15-ezlawk February 20, 2021 10:12 Inactive
@iesahin
Copy link
Contributor Author

iesahin commented Feb 20, 2021

It seems stage now has a tooltip in master and entry in cmd ref. So I'm closing this.

@iesahin iesahin closed this Feb 20, 2021
@iesahin
Copy link
Contributor Author

iesahin commented Feb 20, 2021

This also fixed #1579

@shcheklein shcheklein deleted the iesahin/issue1579 branch April 4, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glossary: create "stage" entry
7 participants