Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarifications around external outputs info. #2154

Merged
merged 4 commits into from
Mar 14, 2021

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Feb 4, 2021

@shcheklein shcheklein temporarily deployed to dvc-landing-guide-exter-kp1d4e February 4, 2021 18:45 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Feb 12, 2021
@shcheklein

This comment has been minimized.

# Managing External Data
# External Outputs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this name was quite intentional as "outputs" is not meaningful for end-users (at the user guide level)...

@jorgeorpinel
Copy link
Contributor Author

I reverted the guide name change in 49eefb0 @shcheklein. PTAL when you have a chance.

@shcheklein shcheklein merged commit 2bce7d5 into master Mar 14, 2021
@jorgeorpinel jorgeorpinel deleted the guide/external-disclaimer branch March 19, 2021 20:40
shcheklein pushed a commit that referenced this pull request Mar 29, 2021
) (#2214)

* guide: disclaim x data (impro #2104)

* Added changes from PR #2188 and modified paths & titles

- Changes title of "Data Access" to "Data and Model Access"
- Changes title of "Data Versioning" to "Data and Model Versioning"
- Renames path of Data Access and Data Versioning to
  `data-and-model-access.md` and `data-and-model-versioning.md`
  respectively.
- Adds redirects
-- `/doc/start/data-access` -> `/doc/start/data-and-model-access`
-- `/doc/start/data-versioning` ->
`/doc/start/data-and-model-versioning`
- Replaces links in `/doc/start` with the new links.

* Update redirects-list.json with fixed subsection redirects.

Co-authored-by: Jorge Orpinel <[email protected]>

* Fixed incomplete looking sentence

* merged into a single paragraph

* Divided models sentence and added "large files" phrase.

* Adds new paths to sidebar

* Updated links to data-access and data-versioning cmd ref

* updated links to data-access and data-versioning in blog

* Updated links to data-access and data-versioning in UC

* Updated links to data-access and data-versioning in UG

* updated yarn.lock

* Update content/docs/start/data-and-model-versioning.md

Co-authored-by: Jorge Orpinel <[email protected]>

* Restyled by prettier

* fixes hardcoded links to data-and-model-access in the blog

* minor fixes

* guide: revert Exp Outs guide rename
per #2154 (review)

* start: emphasize models are files (assumption)

* start: roll back unnecessary changes

unnecessary for #2214

Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: Emre Sahin <iex@levinas>
Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants