Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guide: update links from old "DVC Files" #2117

Merged
merged 6 commits into from
Jan 27, 2021
Merged

guide: update links from old "DVC Files" #2117

merged 6 commits into from
Jan 27, 2021

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Jan 27, 2021 •
edited
Loading

Continues #2098

  • Updates old links to https://dvc.org/doc/user-guide/dvc-files to the new "Project Structure" section, as appropriate (+ copy edits).
  • Review of term "DVC file(s)" - change for new tooltip or use another term (& link).
  • Removes outdated redirects from an even older guide structure (now obsolete, see DVC File guide reorg/rewrite #2098 (review)).
  • Review mentions/links of DVC Internals and .dvcignore
  • Review mentions/links of .dvcignore

@jorgeorpinel jorgeorpinel marked this pull request as ready for review January 27, 2021 04:17
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-h022l5 January 27, 2021 04:17 Inactive
jorgeorpinel
jorgeorpinel commented Jan 27, 2021
View reviewed changes
content/docs/use-cases/data-registries.md
Comment on lines 185 to +186
registry. The result is basically a repo that versions a set of
[metafiles](/doc/user-guide/dvc-files). Let's see an example:
[metafiles](/doc/user-guide/project-structure). Let's see an example:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW the term "metafile" still exists, here and there.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-h022l5 January 27, 2021 04:55 Inactive
jorgeorpinel
jorgeorpinel commented Jan 27, 2021
View reviewed changes
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some instances where the term "DVC file(s)" is used more generally, and this it's intuitive IMO (i.e. I think it's OK in the instances listed below, maybe doesn't even need to be linked?).

content/docs/use-cases/sharing-data-and-model-files.md Outdated Show resolved Hide resolved
content/docs/command-reference/install.md Outdated Show resolved Hide resolved
content/docs/command-reference/install.md Show resolved Hide resolved
@jorgeorpinel

This comment has been minimized.

Sign in to view
@jorgeorpinel jorgeorpinel changed the title guide: update links from old "DVC Files" to new "Project Structure" guide: update links from old "DVC Files" Jan 27, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-h022l5 January 27, 2021 18:51 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-h022l5 January 27, 2021 19:48 Inactive
@jorgeorpinel jorgeorpinel merged commit 41abd3f into master Jan 27, 2021
This was referenced Jan 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeorpinel @shcheklein