-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 Pipelines (parametrization) #2052
Conversation
## Examples: Print all parameters | ||
|
||
Following the previous example, we can use `dvc params diff` to list all of the | ||
param values available in the <abbr>workspace</abbr>: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This example has no changes (which would be out of scope) but I moved the one about Python param files to the bottom so it looks like this is added.
It's the next example the one I added.
98776ed
to
4ec1e99
Compare
601f98a
to
c94bf83
Compare
28706d6
to
204159f
Compare
Okay, it's impossible to iterate on this PR further (GH breaks at this stage, it's impossible to follow all the comments, etc). Let's merge and work separately on the next version. The biggest concern is still structure: All these titles do not look good to me. They are fine for Basic Concepts I guess, but not as a top level section in the User Guide. They should higher level. After that we define the expected structure we can start iterating on the actual content.
|
This comment has been minimized.
This comment has been minimized.
@skshetry I agree that structure is not ideal, we'll iterate on it next thing. Let's merge it and do it in the next PR, this is one is not manageable. Re the split/non-split - to the large extent if feels that it's a matter of preferences and we won't find a solution that fits all. I think the current approach is to keep pages reasonably short, to a single point (e.g. it's bad to have .dvc and the whole dvc.yaml - they are too different concepts. Usual reasons to split (besides personal preferences, which should not serve as an argument unless we do a focus group testing):
Nothing is neglected (e.g. we changed Get started when we had time from 10+ pages to 4). But |
Merged and moved discussion to #2059 (comment). |
@skshetry I don't see how Install pages are spit arbitrarily. But if you'd like to elaborate or have better examples feel free to open a separate issue. Thanks |
DVC Files guide -
dvc.yaml
sectionvars
params diff
" and aboutwdir
.params
cmd ref.term "parametrize" -> "parametErize" + intro "templat(e|ing)"
Follow this up with guide: make proper DVC File guide + separate reference? #2059 immediately after.
Pending: terminology research (see 2.0 Pipelines (parametrization) #2052 (review)).