Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 Pipelines (parametrization) #2052

Merged
merged 50 commits into from
Jan 12, 2021
Merged

2.0 Pipelines (parametrization) #2052

merged 50 commits into from
Jan 12, 2021

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Dec 23, 2020

Based on https://github.com/iterative/dvc/wiki/Parametrization

@shcheklein shcheklein temporarily deployed to dvc-landing-2-0-pipelin-enhjqc December 23, 2020 23:47 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Dec 23, 2020
12 tasks
@jorgeorpinel jorgeorpinel changed the title 2.0 pipelines 2.0 Pipelines (parametrization) Dec 23, 2020
Comment on lines +150 to +153
## Examples: Print all parameters

Following the previous example, we can use `dvc params diff` to list all of the
param values available in the <abbr>workspace</abbr>:
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Dec 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This example has no changes (which would be out of scope) but I moved the one about Python param files to the bottom so it looks like this is added.

It's the next example the one I added.

@jorgeorpinel jorgeorpinel changed the title 2.0 Pipelines (parametrization) 2.0 Pipelines ("parametrization") Dec 24, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc December 24, 2020 04:46 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc December 27, 2020 00:42 Inactive
@jorgeorpinel jorgeorpinel changed the title 2.0 Pipelines ("parametrization") 2.0 Pipelines (ParametErization) Dec 27, 2020
@jorgeorpinel jorgeorpinel changed the title 2.0 Pipelines (ParametErization) 2.0 Pipelines (Parametrization) Dec 27, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc December 27, 2020 03:23 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 04:28 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 04:29 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 04:33 Inactive
jorgeorpinel added a commit that referenced this pull request Jan 8, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 04:38 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 04:38 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 06:02 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 06:22 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 06:27 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 06:33 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 06:39 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 06:45 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 06:47 Inactive
jorgeorpinel added a commit that referenced this pull request Jan 8, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 07:02 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 07:03 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 8, 2021 08:04 Inactive
@shcheklein
Copy link
Member

Okay, it's impossible to iterate on this PR further (GH breaks at this stage, it's impossible to follow all the comments, etc). Let's merge and work separately on the next version. The biggest concern is still structure:

Screen Shot 2021-01-08 at 1 58 52 PM

All these titles do not look good to me. They are fine for Basic Concepts I guess, but not as a top level section in the User Guide. They should higher level.

After that we define the expected structure we can start iterating on the actual content.

  • advanced-dvc.yaml - is too heavy and a mix of a reference (precise spec) and guide (titles are high level, no structure - story like)
  • do we need two seprate dvc.yaml sections? why do we consider basic templating and advanced feature?
  • .dvc file - is clearly a reference thing. Where do we put it?

@skshetry

This comment has been minimized.

@shcheklein
Copy link
Member

shcheklein commented Jan 9, 2021

@skshetry I agree that structure is not ideal, we'll iterate on it next thing. Let's merge it and do it in the next PR, this is one is not manageable.

Re the split/non-split - to the large extent if feels that it's a matter of preferences and we won't find a solution that fits all. I think the current approach is to keep pages reasonably short, to a single point (e.g. it's bad to have .dvc and the whole dvc.yaml - they are too different concepts. Can dvc.yaml fit a single page - good question-let's see in the next PR. I really hope so, I'm though worried that about some points I describe below, e.g. complexity of the right hand bar).

Usual reasons to split (besides personal preferences, which should not serve as an argument unless we do a focus group testing):

  • have a clear link to separate page that describes one thing (good for SEO, since term becomes part of the URL, page has tailored meta section, etc)
  • when you have too much on a single page- you won't have any navigation at all (due to multiple levels of nesting). Or we'll have to complicate right hand side bar.

Why is it neglected so much?

Nothing is neglected (e.g. we changed Get started when we had time from 10+ pages to 4). But I find traversing through those pages difficult is not an argument that we can use as a guideline to my mind. If you have some good structure or guideline in mind, please suggest it.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2-0-pipelin-enhjqc January 12, 2021 05:51 Inactive
@jorgeorpinel jorgeorpinel merged commit f744fcc into master Jan 12, 2021
@jorgeorpinel
Copy link
Contributor Author

Merged and moved discussion to #2059 (comment).

@jorgeorpinel
Copy link
Contributor Author

It feels like we are splitting pages arbitrarily (just look at installation instructions).

@skshetry I don't see how Install pages are spit arbitrarily. But if you'd like to elaborate or have better examples feel free to open a separate issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants