Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: reorder how-tos and copy edits; expand on adding existing dependencies to a stage #1914

Merged
merged 27 commits into from
Nov 27, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Nov 9, 2020

Let's incorporate these changes to #1913 and close this PR.

This PR will now also incorporate #1913 (review)


Fixes #460 (How to add dependencies to a stage without re-running it)

@shcheklein shcheklein temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 9, 2020 04:27 Inactive
imhardikj added a commit that referenced this pull request Nov 9, 2020
@jorgeorpinel jorgeorpinel marked this pull request as ready for review November 10, 2020 23:08
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 10, 2020 23:08 Inactive
@jorgeorpinel jorgeorpinel changed the title guide: reorder how-tos and some copy edits guide: reorder how-tos and copy edits; expand on adding existing dependencies to a stage Nov 10, 2020
@shcheklein shcheklein temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 11, 2020 17:09 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 11, 2020 17:34 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 12, 2020 02:43 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 12, 2020 03:19 Inactive
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of copy edits above, and a couple more relevant comments ☝️

Thanks

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 25, 2020 05:23 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 25, 2020 05:30 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 25, 2020 06:04 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 25, 2020 06:23 Inactive
perhttps://github.com//pull/1914#pullrequestreview-538204006 etc.
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 25, 2020 23:00 Inactive
jorgeorpinel added a commit that referenced this pull request Nov 27, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 27, 2020 06:26 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 27, 2020 06:37 Inactive
@@ -1,76 +1,72 @@
# Updating Tracked Files
# How to Update Tracked Files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files or Data - in some case we use Data, in some cases Files. is it okay?

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Nov 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data is better but this is a pre-existing use case and renaming it is a bit out-of-scope, esp. since it requires a redirect.

TBH I want to move other guides into this section: Merge Conflicts and Setup a Google Drive Remote for starters (also need redirects). So should we do all that in a separate PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we do all that in a separate PR?

yes, def not this PR!

Setup a Google Drive Remote

this should part of a bigger section that has a page per remote type. It's not How to

Merge Conflicts

It can be probably part of the How to indeed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup a Google Drive Remote...
should part of a bigger section that has a page per remote type. It's not How to

I think it's definitely "how-to" material, even if we put that remote config section somewhere else. I'll let it be for now then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put pretty much anything into How to this way ... How to manage external data, How to contribute, How to optimize deal with large data, How to run on Windows, etc ...

I think there should be something else that defines this section - closer to FAQ? some specific workflow questions?

In case of Google Drive - we'll have one page per remote. Even size in this case makes a bad fit. Eventually it might become bigger than everything else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continued in #1976

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, just a few comments left - I would simplify the title.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-how-to-cb6eiv3d2sr November 27, 2020 22:25 Inactive
@jorgeorpinel jorgeorpinel merged commit 143f730 into master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd ref: improve run and commit / how to add outs/deps without re-running stage?
3 participants