Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cases: Versioning Data and Models (rewrite) #1747
cases: Versioning Data and Models (rewrite) #1747
Changes from 99 commits
39d4400
87264eb
8bdae1d
1679c59
a794600
ab35693
5ed0d75
c291558
a3008c8
ca062b2
7a4cec6
9e564e3
9d5dca1
c188146
1f4f2f0
c554b67
de07dfa
daa99a0
02568e7
79d9b0b
8ddc976
ae8e7ad
09d1eab
7ea83bf
e90d332
5f47377
f36d10b
b9ea7ec
3fdddf2
ce647f5
bc7018b
62a34db
81d848b
1898ccf
c6d969c
f447b14
384218d
7facdf7
8f3cb70
c0b6b58
17f80b8
018c3f3
b63bc7f
0ec7350
68619f1
12bc7ed
78426d1
bc7ff0a
53b65c2
579cc5b
fb7265c
c9d0444
f49cce6
5b95d36
aeb860e
2c7e2ea
da9390a
30ad4e7
c5e34ce
04e42cb
531071a
40f09df
8fcd2e6
669f9f5
67c6beb
4329b60
8ca6ef1
8b81ac3
66b0829
49adf55
aa6c43e
3c61ea7
b74e687
f02c1a7
63970bc
e6ce632
88ff11a
aeacb1f
3956590
eeccb68
7c22613
00b88e1
4436600
702d619
00dc2d6
5edf502
21fce9b
c0142c2
6cab1f3
24a00cd
b1d75c7
8307583
79a071a
953c16b
52ea945
2b0d183
98b3135
87b8333
59fc3f9
7677d25
a6f3352
9644a38
0e47977
8bd9d96
1686639
4ab5ed4
1b48db2
0fbf200
c7617ef
aa62d9d
c14a271
020fb3f
1a3a58c
f6598bd
98d97c7
6a75449
d6697dc
2ccd32e
0d093b8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit too abstract. I'd suggest moving it down in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I moved it down for now.
But I thought this was a pretty key purpose of versioning in general. Maybe we can rewrite it in a less conceptual terms, but I'm not sure how.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we make it less abstract?
it's an important point to my mind (even more important than a Tidy project (Simple names now))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I put in on the top 😆 for now. But we should come up with a criteria do decide which ones go first... After we decide which benefits to even keep (too many rn probably).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmpetrov 's point stays - if it feels abstract, should we reconsider the description? make Reproducibility and something in bold?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is back around the middle and the other benefits have been generalized more so maybe now they all have a consistent level of abstraction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd separate this into two:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that compliance is a better term, thanks! Updated along the lines you suggested.
Data security: maybe we don't need this benefit? Especially if we decide not to cover storage in this doc (per #1747 (comment) above). I removed it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data compliance should be probably part of the Git flow? or Git flow can be replaced by it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generalized all benefits into 5 now, PTAL. But the problem with Git workflows is that it has too many sub-benefits and it would be a huge paragraph if we include everything. I think Data compliance is a high-level benefit of it's own anyway?
We're even missing data security but per the comments above it sounds like it would be better to list it in https://dvc.org/doc/use-cases/sharing-data-and-model-files (as it has more to do with remote storage).