Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: simplify project nesting info in init #1664

Closed
wants to merge 9 commits into from

Conversation

jorgeorpinel
Copy link
Contributor

Notes extracted from #1661:

Ideally not but yes in the way things are structured now in this ref. This isolation and nested situation got too complicated... I should probably make a separate sub-section to cover it after explaining all the 3 kinds of projects (typical or git-enabled, --subdir, --no-scm).

On Git submodules: "I would expect from people who use submodules have the same intuition by default - isolated in Git, isolated in DVC - nothing special or specif", "True, I can just remove it and handle them via support channel if needed" (from #1615 (review))

On block code examples for nested repos: ".git still not important here" (from #1615 (review))

@shcheklein shcheklein temporarily deployed to dvc-landing-cmd-init-ne-juucow August 6, 2020 02:28 Inactive
@jorgeorpinel jorgeorpinel changed the title cmd: explain project/repo nesting in init ref. cmd: simplify project nesting info in init Aug 6, 2020
@shcheklein
Copy link
Member

@jorgeorpinel I think it was in a decent shape. Let's leave as is for now?

@jorgeorpinel jorgeorpinel marked this pull request as ready for review August 6, 2020 07:21
@jorgeorpinel
Copy link
Contributor Author

Yeah sorry, I couldn't help myself from pushing these changes. Only took me like 10 min. Basically the code block examples in --subdir are removed, this simplifies the cmd ref a little. Everything else are copy edits. See https://dvc-landing-cmd-init-ne-juucow.herokuapp.com/doc/command-reference/init

But if you prefer to close this that's also OK, I'll re-apply the copy edits in a small regular updates PR that I probably need to submit tomorrow. Thanks

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-cmd-init-ne-juucow August 6, 2020 07:24 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-cmd-init-ne-juucow August 6, 2020 07:44 Inactive
@shcheklein
Copy link
Member

@jorgeorpinel we have some unrelated changes here now? was it intentional?

I still don't see a strong reason to touch it (except small copy edits). Let's create a ticket if needed, prioritize and discuss it there first.

@jorgeorpinel
Copy link
Contributor Author

some unrelated changes here now?

Oops those were meant for another branch...

@jorgeorpinel jorgeorpinel mentioned this pull request Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants