-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dvc root command reference motivation and examples #1637
Conversation
That's checked automatically by Github and Restyled (shown in the bottom PR summary). You can see all the checks in that section of the PR (inside "test", specifically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Jeremy. Thanks for the PR.
I haven't checked the examples yet but the description didn't fully convince me.
I left specific comments ☝️
Thanks Jorge. Made changes based on your feedback and left comments open. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more questions on the description. Thanks
@jeremydesroches please check #404 (comment) before continuing here 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you added Examples @jeremydesroches. Thanks, I'll review them. But please first make sure the old ones (first 2) are "actionable and meaningful. It's should be easy to run commands to see the results", per #404
I reviewed the existing two examples before adding the new ones. The first example is still meaningful and actionable because it's important to show that I adjusted the second example to make it more a meaningful and useful (while keeping it simple). The updated version uses |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some more comments above ☝️
And a review of the Examples below 👇
## Example: Build reusable paths | ||
|
||
Build reusable paths to dependencies, scripts, or <abbr>data artifacts</abbr> | ||
from separate stages and subdirectories. | ||
|
||
```dvc | ||
$ cd more_stages/ | ||
$ dvc run -n process_data \ | ||
-d data.in \ | ||
-d $(dvc root)/process_data.py \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK... I think what we need is a shell script that generates a dvc.yaml file instead of another dvc run
example. Not required for this PR, so if you're not so familiar with Linux shell just leave it out for now please. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this for now.
I looked into some related issues (#615) and examples of scripts.
These make sense within the scripting use case but instead of adding a (complicated) example that builds out a full set of stages, it would help to have the team vet a smaller example that fits the recommended usage.
Co-authored-by: Jorge Orpinel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK this is ready I think. I'll just commit my couple pending suggestions and merge this.
Updates motivation and examples. See issue #404.