Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repro 1.x : Updated downstream example and added info for Sequential execution. #1624

Merged
merged 18 commits into from
Jul 31, 2020
Merged

repro 1.x : Updated downstream example and added info for Sequential execution. #1624

merged 18 commits into from
Jul 31, 2020

Conversation

sarthakforwet
Copy link
Contributor

PR as an outcome of discussion at #1572(review).

jorgeorpinel
jorgeorpinel suggested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct intentions, thanks! Some details to fix below:

content/docs/command-reference/repro.md Outdated Show resolved Hide resolved
content/docs/command-reference/repro.md Outdated Show resolved Hide resolved
content/docs/command-reference/repro.md Outdated Show resolved Hide resolved
content/docs/command-reference/repro.md Outdated Show resolved Hide resolved
@jorgeorpinel jorgeorpinel mentioned this pull request Jul 24, 2020
Merged
@jorgeorpinel
Copy link
Contributor

Also, the changes per #1572 (review) may also be missing still, but if it's too confusing or doesn't seem to apply now please lmk @sarthakforwet and I'll take care of it.

@weekly-digest weekly-digest bot mentioned this pull request Jul 26, 2020
Closed
jorgeorpinel
jorgeorpinel suggested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes needed ☝️

jorgeorpinel
jorgeorpinel approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to take a quick final look before I merge this @shcheklein ? Thanks

And thanks again, @sarthakforwet

@shcheklein shcheklein temporarily deployed to dvc-landing-repro-misc-z88dnez July 31, 2020 20:33 Inactive
shcheklein
shcheklein approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! just a few typos.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-repro-misc-z88dnez July 31, 2020 21:58 Inactive
@restyled-io restyled-io bot mentioned this pull request Jul 31, 2020
Merged
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-repro-misc-z88dnez July 31, 2020 21:59 Inactive
@jorgeorpinel jorgeorpinel merged commit 012b72f into iterative:jorge Jul 31, 2020
@jorgeorpinel
Copy link
Contributor

Merged #1648!

@sarthakforwet sarthakforwet deleted the repro_misc branch August 1, 2020 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarthakforwet @jorgeorpinel @shcheklein