-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
July gems #1616
July gems #1616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some cleanup is still needed. do we have more DVC/CML question - if we remove the huge YAML (and I would keep it in docs only) we won't have enough content to my mind
@shcheklein yep, we've got some more questions pinned in Discord. Let's move the big yaml snippet to docs and add another 2 questions or so. |
- CML | ||
- Bitbucket | ||
- GCP | ||
- global remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both cache and global remote sound like too specific, ad-hoc terms to my mind
I think we have Gems usually, Discord
again, not sure about terms like Bitbucket for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead we can mention this things in the descriptionLong (is it intentional that we miss it, btw?) for SEO I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also- for some reason I thought that if we had only one description text, we should only use the "description" field, not both "description" and "descriptionLong". Is that incorrect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be, but I don't remember which way it goes // cc @rogermparent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list of tags looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have any explicitly defined behavior in mind when implementing description
and descriptionLong
in the models, but I can pretty easily add functionality to seamlessly use description
as descriptionLong
's slot if descriptionLong
isn't present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about this logic:
{descriptionLong ? (
<div
className={styles.description}
dangerouslySetInnerHTML={{ __html: descriptionLong }}
/>
) : (
<div className={styles.description}>{description}</div>
)}
for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elleobrien I think the simplest for now is just implement both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I hadn't checked the template yet and was looking at the data layer. You're right, the behavior is already implemented in the template.
The description also shows up when I clone the repo locally. This smells like a caching issue, but I'm not 100% sure yet.
|
||
When you | ||
[create a global DVC remote](https://dvc.org/doc/command-reference/remote/list#options), | ||
a config file will be created in `~/.config/dvc/config` instead of in your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of in
- something is missing here?
also, we should probably mention location on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea but i can't find in the docs anything about the cache location in windows- can you point me to it, @shcheklein?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean config ... good point ... @efiop do you remember this by chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ruslan 4:10 PM
IIRC
C:\Users\<username>\AppData\Local\iterative\dvc\config
C:\ProgramData\iterative\dvc\config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the config is saved in two places on a Windows system, or one is an an alias of the other? Or it will be in one of those two locations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C:\Users\<username>\AppData\Local\iterative\dvc\config
corresponds to global
I guess.
file in your remote within a Python environment. | ||
[Check out our API docs!](https://dvc.org/doc/api-reference/get_url) | ||
|
||
### [Q: By default, each DVC project has its own cache in the project repository. To save space, I'm thinking about locally creating a single cache folder and letting multiple project repositories point there. Will this work?](https://discordapp.com/channels/485586884165107732/563406153334128681/736164141701791815) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discord link is broken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like a problem with Discord- I've navigated to the message and copied the link, but Discord is giving the same link, and it directs to the bottom of the channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this. See a few comments. Feel free whenever you feel it's ready.
Here's the July Community Gems PR- will update link to comments & image shortly.
I have 3 DVC questions and 4 CML questions and the length seems right to me. But if you have a favorite DVC question or two to add, please suggest.
@dmpetrov would appreciate your quality check on CML answers :)