Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: smooth: example #1604

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Conversation

pared
Copy link
Contributor

@pared pared commented Jul 20, 2020

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fixes #1439

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Let's may be mention in the description (and may be in the -t option) something like e.g. you can use it to make it smooth (see [example](link))

@pared pared force-pushed the 1439_smooth_example branch 2 times, most recently from 57b3d6e to 76fc742 Compare July 21, 2020 09:14
@pared
Copy link
Contributor Author

pared commented Jul 21, 2020

@shcheklein I think that adding note to -t would be unfair to our other plots, so I summarized what templates are avialable under plots/plot-templates

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy edits (may need formatting):

content/docs/command-reference/plots/index.md Outdated Show resolved Hide resolved
content/docs/command-reference/plots/index.md Outdated Show resolved Hide resolved
@pared pared force-pushed the 1439_smooth_example branch from 515c111 to 92330af Compare July 22, 2020 07:49
@pared
Copy link
Contributor Author

pared commented Jul 22, 2020

@jorgeorpinel squashed and reformatted

@shcheklein shcheklein merged commit fa5db1e into iterative:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plots: add smooth template example
4 participants