Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CloudFlare cache cleaner logging + Stars bugfix (second attempt) #1600

Merged
merged 9 commits into from
Jul 20, 2020

Conversation

rogermparent
Copy link
Contributor

This is the same PR as before, but with a slight change to fix the server invocation.

This time I'll confirm the review app before I suggest a merge.

Since Heroku's runtime logs are much trickier to track down than dyno runtime
logs, this change will allow us to better see CloudFlare cache clearing
feedback.

The script in `clear-cloudflare-cache` is changed from a shell-invoked style to
a Node module that's imported into `deploy-with-s3`.
This replaces the Node with a Resolver, so the in-between layer is thinner and
not subject to stale cache pruning as it is only a middleman.

This also adds `createResolvers` to Gatsby APIs exposed to Models
@shcheklein shcheklein temporarily deployed to dvc-landing-fix-cloudfl-jkfbz8 July 20, 2020 02:33 Inactive
@rogermparent
Copy link
Contributor Author

Yep, adding node back to the invocation makes the proxy server actually work!

https://dvc-landing-fix-cloudfl-jkfbz8.herokuapp.com/

@shcheklein
Copy link
Member

Deploying? :)

@rogermparent rogermparent mentioned this pull request Jul 20, 2020
@rogermparent
Copy link
Contributor Author

rogermparent commented Jul 20, 2020

Yep, it's deploying successfully now! With the slight change to the start script, deploy previews show up successfully. I must have been using only gatsby serve before and missed where I broke the server invocation because it can't be directly run like clear-cloudflare-cache was before.

@shcheklein shcheklein merged commit d1bd6e3 into master Jul 20, 2020
@rogermparent
Copy link
Contributor Author

rogermparent commented Jul 20, 2020

Yay! The site's not broken! In this aspect, at least.

@rogermparent rogermparent deleted the fix-cloudflare-cache-clearer branch July 20, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants