-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cache pruning #1557
Merged
Merged
Fix cache pruning #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
approved these changes
Jul 10, 2020
From the preview logs:
Wow, that's more than I thought there would be! Anyway, this confirms the pruner working in this PR. |
https://dvc-landing-fix-cache-p-yjhtrb.herokuapp.com/doc/command-reference/metrics/add And here's a proper 404 on a previously stale page! |
Thanks @rogermparent ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1405, which I've confirmed is a cache issue with local testing.
We totally have a tool that prunes cache to solve that, I must have accidentally broken the invocation earlier before starting work on the CML site.
This PR turns the weird function-but-not-model pruner into a model like the other pieces of
gatsby-node
logic we use, both cleaning it up and fixing the invocation.