docs: update virtualenv links #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeorpinel
commented
Jul 10, 2020
Comment on lines
-117
to
+120
| [virtual environment](https://packaging.python.org/tutorials/installing-packages/#creating-virtual-environments): | ||
| [virtual environment](https://python.readthedocs.io/en/stable/library/venv.html): | ||
|
|
||
| ```dvc | ||
| $ virtualenv -p python3 .env | ||
| $ python3 -m venv .env |
There was a problem hiding this comment.
Should we remove the actual command from these though?
shcheklein
approved these changes
Jul 10, 2020
jorgeorpinel
commented
Jul 10, 2020
| > [virtual environment](https://packaging.python.org/tutorials/installing-packages/#creating-virtual-environments) | ||
| > [virtual environment](https://python.readthedocs.io/en/stable/library/venv.html) |
There was a problem hiding this comment.
For example we don't put the command in the installation pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #1553 (review)
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏