Add GitHub link icon to CML alert bar #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not the most reusable implementation, but it does the job.
Since the nav menu isn't in the header's tree, this fix has the menu icon invoke the header hook separately and restyle itself alongside the header.
This also fixes the SocialIcon GitHub link to be currentColor, as this commit re-uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original suggestion was to have a ":star: us on GitHub" string or button appended, but wrapping lines on this thing is trickier than it looks (there's a whole lot of disjointed fixed positioning)
This is a quick compromise that adds a github link in a sensible way with minimal extended length.