Add an alert box above the header to advertise CML #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not the most reusable implementation, but it does the job.
shcheklein
reviewed
Jul 7, 2020
| @@ -28,6 +28,10 @@ const LayoutHeader: React.FC<Required<ILayoutModifiable>> = ({ modifiers }) => { | |||
| )} | |||
| /> | |||
| <div className={styles.header}> | |||
| <div className={cn(styles.alert, collapsed && styles.collapsed)}> | |||
| Check out the newest tool from Iterative,{' '} | |||
There was a problem hiding this comment.
let's add a bit more fun here:
🚀 Check out the newest tool
- make font bigger
- do not mention Iterative
jorgeorpinel
reviewed
Jul 7, 2020
| <span role="img" aria-label="rocket"> | ||
| 🚀 | ||
| </span> | ||
| Check out the newest tool, |
There was a problem hiding this comment.
Needs a space e.g.
Suggested change
| Check out the newest tool, | |
| Check out the newest tool, |
jorgeorpinel
reviewed
Jul 7, 2020
Comment on lines
+35
to
+36
| Check out the newest tool, | ||
| <Link href="https://cml.dev">CML</Link>! |
There was a problem hiding this comment.
Needs a space e.g.
Suggested change
| Check out the newest tool, | |
| <Link href="https://cml.dev">CML</Link>! | |
| Check out the newest tool, | |
| <Link href="https://cml.dev">CML</Link>! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure we'll want changes to the text and color, but here's the implementation!
The current implementation is a simple div placed above the header, which collapses to zero height whenever the header collapses. This behavior can also be changed, especially if it has problems on corner cases.