term : remove "Dvcfile" from versioning use case tutorial #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeorpinel
reviewed
Jul 6, 2020
content/docs/use-cases/versioning-data-and-model-files/tutorial.md
Outdated
Show resolved
Hide resolved
jorgeorpinel
reviewed
Jul 6, 2020
content/docs/use-cases/versioning-data-and-model-files/tutorial.md
Outdated
Show resolved
Hide resolved
jorgeorpinel
reviewed
Jul 6, 2020
content/docs/use-cases/versioning-data-and-model-files/tutorial.md
Outdated
Show resolved
Hide resolved
jorgeorpinel
suggested changes
Jul 6, 2020
Comment on lines
326
to
328
| `dvc run` creates a pipeline stage named `train` (specified using the `-n` | ||
| option) in [`dvc.yaml`](/doc/user-guide/dvc-files-and-directories#dvcyaml-file) | ||
| file. It tracks all outputs (`-o`) the same way as `dvc add` does. Unlike |
There was a problem hiding this comment.
Suggested change
| `dvc run` creates a pipeline stage named `train` (specified using the `-n` | |
| option) in [`dvc.yaml`](/doc/user-guide/dvc-files-and-directories#dvcyaml-file) | |
| file. It tracks all outputs (`-o`) the same way as `dvc add` does. Unlike | |
| `dvc run` writes a pipeline stage named `train` (specified using the `-n` | |
| option) in [`dvc.yaml`](/doc/user-guide/dvc-files-and-directories#dvcyaml-file). | |
| It tracks all outputs (`-o`) the same way as `dvc add` does. Unlike |
There was a problem hiding this comment.
Do we need to change it from here also?
There was a problem hiding this comment.
Yes but it's out of scope. The whole ref. needs to be rewritten soon. I'm committing my suggestion above to save time. Please just fix the formatting. Resolving here.
There was a problem hiding this comment.
Actually the command was already rewritten so yes, just this intro to that command should be rephrased... But still, out of scope for this PR. I'll send a separate one.
content/docs/use-cases/versioning-data-and-model-files/tutorial.md
Outdated
Show resolved
Hide resolved
content/docs/use-cases/versioning-data-and-model-files/tutorial.md
Outdated
Show resolved
Hide resolved
…l.md Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
jorgeorpinel
approved these changes
Jul 6, 2020
jorgeorpinel
approved these changes
Jul 6, 2020
|
Merged the restyled PR instead. Thanks @sarthakforwet |
jorgeorpinel
added a commit
that referenced
this pull request
Jul 6, 2020
shcheklein
pushed a commit
that referenced
this pull request
Jul 6, 2020
shcheklein
pushed a commit
that referenced
this pull request
Jul 7, 2020
* cmd: rephrase intro of run per #1526 (comment) * cmd: typo in run -h out per #1537 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR completes the below subtask from #1445.